Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reauth flow does not have access to {name} placeholder in title #128839

Closed
rappenze opened this issue Oct 20, 2024 · 1 comment · Fixed by #128925
Closed

Reauth flow does not have access to {name} placeholder in title #128839

rappenze opened this issue Oct 20, 2024 · 1 comment · Fixed by #128925

Comments

@rappenze
Copy link
Contributor

rappenze commented Oct 20, 2024

The problem

The title of the reauthentication dialog can not be shown because the placeholder {name} is not available.
I have seen that behaviour in the fibaro integration but I think it is a general problem.

I checked in the debugger that title_placeholders is set in the context of the config flow, but it is not used when rendering the text. I'm not sure if this is a backend or a frontend problem.

In the image you can see that the title for the repair notification is set correctly, but in the config flow dialog where the same title is displayed the {name} parameter is missing and therefore an error is displayed.

image

What version of Home Assistant Core has the issue?

core-2024.11.0.dev0

What was the last working version of Home Assistant Core?

unknown

What type of installation are you running?

Home Assistant OS

Integration causing the issue

config

Link to integration documentation on our website

https://www.home-assistant.io/integrations/config/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

2024-10-20 09:46:30.121 ERROR (MainThread) [frontend.js.modern.202410023] Failed to format translation for key 'component.fibaro.config.step.reauth_confirm.title' in language 'de'. Error: The intl string context variable "name" was not provided to the string "Authentication expired for {name}"

Additional information

No response

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this issue as it has been labeled with an integration (config) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of config can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign config Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


config documentation
config source
(message by IssueLinks)

@rappenze rappenze changed the title Reauth flow does not access to {name} plaeholder in title Reauth flow does not have access to {name} placeholder in title Oct 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant