Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Early Access warning dismissal constantly reappears #118134

Closed
doctorkb opened this issue May 25, 2024 · 10 comments
Closed

Early Access warning dismissal constantly reappears #118134

doctorkb opened this issue May 25, 2024 · 10 comments

Comments

@doctorkb
Copy link

The problem

The "UniFi Protect Early Access Enabled" repair re-appears often, despite having been dismissed.

This shouldn't be a warning but once -- it should be switch or check-box in the Integration configuration, which can be retained.

What version of Home Assistant Core has the issue?

core-2024.5.5

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

UniFi Protect

Link to integration documentation on our website

https://www.home-assistant.io/integrations/unifiprotect

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

@home-assistant
Copy link

Hey there @bdraco, mind taking a look at this issue as it has been labeled with an integration (unifiprotect) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of unifiprotect can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign unifiprotect Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


unifiprotect documentation
unifiprotect source
(message by IssueLinks)

@gpf2ez
Copy link

gpf2ez commented May 28, 2024

I have been having the same issue also. I even removed my protect from early access and it still alerts.

@doctorkb
Copy link
Author

Found a solution (maybe?) - tick the unlabelled box in the UniFi Protect HA Integration Configuration and submit:
image

With that in mind - perhaps this Issue should be updated to label that box?

@gpf2ez
Copy link

gpf2ez commented May 28, 2024

Found a solution (maybe?) - tick the unlabelled box in the UniFi Protect HA Integration Configuration and submit: image

With that in mind - perhaps this Issue should be updated to label that box?

This did not work for me.

@alexruffell
Copy link

alexruffell commented Jun 11, 2024

If the issue is the nagging reminder that you installed an unsupported version, then it is not a bug but intentional. I believe it re-appears at every boot which due to all my tinkering with HA and the underlying Proxmox is often enough to make it irritating. When I asked about it (thought it wasn't supposed to keep showing up) I got schooled on how inefficient and annoying it is for tons of users demanding developers fix unsupported Unifi software, and I totally understand them! We (users) are told to file github issues when stuff doesn't work but that only applies to what is intended to work... fine line that is not always obvious.

Anyway there is a fix, and I hope I won't get chastised for sharing it openly (it was shared with me as a hint to figure out so not as openly).

There is an "allow_ea_channel": true option in core.config_entries file that defaults to false which can be easily changed with a text editor... BUT... DISCLAIMER: You can easily break HA by modifying that file, and who knows maybe even end up needing to reinstall so only do this at your own risk and without expecting HA developers to fix your issue (I can't speak for them, but I'd say "you are on your own" is most reasonable here).

Edit: In the spirit of being helpful, if you need extra information to make the above change, then please don't do it and please don't ask me for help as I don't want to be responsible for broken HA installs :) I mean this in the most kind way possible!

Edit2: Once removed, please remember not to complain/nag when using unsupported Unifi software and stuff breaks as that was the intent of the nag. However, EA stuff becomes GA quite fast with Unifi so.... wouldn't it help devs to know in advance when stuff is going to break? Maybe a dev can suggest a way for us to help in that regard.

@doctorkb
Copy link
Author

If the issue is the nagging reminder that you installed an unsupported version, then it is not a bug but intentional. I believe it re-appears at every boot

That's a bug. It should warn once, force an acknowledgement, then not warn again (at least not for a minimum period of time - say 90 days - or no version change). Any more than that is just keeping with the previous maintainer's hatred for Ubiquiti.

When I asked about it (thought it wasn't supposed to keep showing up) I got schooled on how inefficient and annoying it is for tons of users demanding developers fix unsupported Unifi software

I think there's a difference between demanding something work, and using the EA versions to figure out what is going to break, and reporting it accordingly to those maintaining those things. That is, after all, the intent of an EA program -- discover what needs to be fixed so when it is released, the various integrations are ready to handle it, rather than being broken for several weeks while they go through a release cycle.

The previous code maintainer for this integration is quite the piece of work (there are a few threads around with how he's taken his ball and gone home -- changing the license for his work with a poison pill aimed at Home Assistant). With the vitriol he was putting out, you'd think people were sending him body parts of his relatives as threats.

Anyway there is a fix, and I hope I won't get chastised for sharing it openly (it was shared with me as a hint to figure out so not as openly).

If anyone chastises you for something like this, that's their problem, not yours.

@alexruffell
Copy link

@doctorkb While I agree the warning should be shown once, I believe it was the dev you are referencing that told me it was intentional and therefore not a bug. Either way, he did drop a hint (see my post above) on how to get rid of the nag. I figured out what he meant and very happily fixed it on my end.

Unifi EA software is meant to help Unifi fix their issues. However, if I were a HA integration developer, I would likely want to be on the forefront (aka use EA) so that I can fix stuff before it becomes GA... BUT... at least one developer wrote he uses his own system and running EA would require him to have duplicate hardware which can be problematic at times especially when you consider their development and support efforts are contributed for free. My concern about being chastised for sharing it, is mostly because I am trying to help users WITHOUT causing more work/issues for HA developers.

Anyway, I don't want to get tangled in a what is right or wrong debate but rather provide relief from the nag by sharing that tip in my previous post.

@u20p17
Copy link

u20p17 commented Jun 12, 2024

I also think that like it is now is not intended... I am quite a while on the EA channel and also using the HA integration and up to now I got the warning only once and after updates. Now I get it all the time - I accept it and some seconds later it appears again. For me this is no big problem, but I am quite sure it is not intended to behave like this...

@bdraco
Copy link
Member

bdraco commented Jun 15, 2024

There were some fixes in 2024.6.3 that may have solved this, but I don't have a system running EA to validate the fixes with so I'm not sure either way. Maybe someone can report back.

@u20p17
Copy link

u20p17 commented Jun 17, 2024

it seems that it is fixed. I updated to 2024.6.3 (and I am on EA) and the message didn't pop up since then. Thanks!

@bdraco bdraco closed this as completed Jun 17, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants