Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HomeWizard and 2023.12 #105242

Closed
frankie-boy-hgv opened this issue Dec 7, 2023 · 8 comments · Fixed by #105251
Closed

HomeWizard and 2023.12 #105242

frankie-boy-hgv opened this issue Dec 7, 2023 · 8 comments · Fixed by #105251

Comments

@frankie-boy-hgv
Copy link

The problem

In 2023.12 things changed: https://github.com/home-assistant/core/pull/104493 2
Unfortunately I had to change my sensor in the Energy Dashboard, but now I’ve lost my history:
See: https://community.home-assistant.io/t/homewizard-and-2023-12/651743

I fixed it like it was mentioned in the thread, linked above, but it should be fixed for others imho.

What version of Home Assistant Core has the issue?

core-2023.12.0

What was the last working version of Home Assistant Core?

core-2023.11.5

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Updating from 2023.11.5 to 2023.12.0

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

@home-assistant
Copy link

home-assistant bot commented Dec 7, 2023

@home-assistant
Copy link

home-assistant bot commented Dec 7, 2023

Hey there @DCSBL, mind taking a look at this issue as it has been labeled with an integration (homewizard) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of homewizard can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign homewizard Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


homewizard documentation
homewizard source
(message by IssueLinks)

@erikgeurts
Copy link

When I read the release notes for 2023.12 I realized immediately that this would create problems for many owners of these devices. In my case, all of the plugs and both of the kWh meters I own have the sensors for tariff 1 only, and no sensor for the generic measurement. So if I had updated I would have lost all history on all of these measurements, and a lot of dashboarding and automations would have broken at the same time.

I'm glad I stumbled on this issue, and the PR that's going to fix this in 2023.12.1, and I'm glad also that it is my habit to never update immediately when a new month release is out, but to wait for at least the first bug fix and sometimes even more.

@frankie-boy-hgv
Copy link
Author

When I read the release notes for 2023.12 I realized immediately that this would create problems for many owners of these devices. In my case, all of the plugs and both of the kWh meters I own have the sensors for tariff 1 only, and no sensor for the generic measurement. So if I had updated I would have lost all history on all of these measurements, and a lot of dashboarding and automations would have broken at the same time.

I'm glad I stumbled on this issue, and the PR that's going to fix this in 2023.12.1, and I'm glad also that it is my habit to never update immediately when a new month release is out, but to wait for at least the first bug fix and sometimes even more.

If no one tried a .0, issues would never appear ;-).
And luckily, a restore from a backup can always be done.

@bruin14
Copy link

bruin14 commented Dec 11, 2023

It amazes me how easy this is closed as solved. If you have multiple sockets (not the P1 meter) you have lost all you history in a blink. As far as i can tell you can't replace the sensor if its a individual device. I can just add the new sensor.

@erikgeurts
Copy link

erikgeurts commented Dec 14, 2023

If no one tried a .0, issues would never appear ;-). And luckily, a restore from a backup can always be done.

This is the kind of issue that would/should have popped up during beta testing, not in a production release.

@DCSBL
Copy link
Contributor

DCSBL commented Dec 14, 2023

Then we need more beta testers ;).

@erikgeurts
Copy link

Then we need more beta testers ;).

Indeed, but I can't afford to spend time beta testing every project I use. I have more than enough work "dog fooding" my own open source project: https://github.com/revive-adserver/revive-adserver/ and several others.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants