-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trusted Networks Auth Provider enhancement #169
Comments
How are you differentiating between group and user ids ?
|
First version will only support user. No good way in my mind to distinguish user and group. Maybe we can use |
In YAML, you can actually do For auth config, it needs to be crystal clear. I rather have it be too verbose, there is no room for mistakes. |
Maybe allow for a dictionary as value for
Would maintain backwards-compatibility while allowing for the new options to be used without duplicating the network cidrs under multiple keys. |
BTW, Do we want to sort the networks by longest prefix as in routing tables, so that smaller parts of a larger subnet can have a different config? |
I am not the fun mixed networks and users together. Because user may choose only assign user to partial of trusted network. In that case, you can select all available users from login form. Sort networks is a good idea. We should do it. |
Hmm, wouldn't sorting the networks by prefix length provide just that - the ability to assign particular users to a smaller subnet of a larger trusted network? For a backwards-compatible syntax, I could also think of something like this:
|
Current
Since 0.89, Trusted Networks Auth Provider will load its own config.
Proposed Change
The changes around the user list provided in the login form, depends on where the request is coming from, the user list could be different
Especially if
bypass_login
is enabled and only one user could be chosen, the login form could be skipped.Migration / Breaking Changes
No issue, all options are additional
EDIT: modify group base on feedback
The text was updated successfully, but these errors were encountered: