Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar problem in "location_disabled_notification_short_message"/"location_tracking_summary" #4739

Closed
NoRi2909 opened this issue Oct 17, 2024 · 7 comments · Fixed by #4741
Closed
Labels
bug Something isn't working

Comments

@NoRi2909
Copy link
Contributor

Home Assistant Android app version:
2024.10.3-full (beta)

The string location_disabled_notification_short_message is currently

"Some setting(s) do not work"

If you read this as singular the grammar is broken, should be "does" in that case.
It's also quite difficult to properly translate into German (or other languages).

Perhaps using just plural is fine, too:

"Some settings do not work"

You might want to apply the same fix to:

location_tracking_summary

"View a history of location tracking updates to troubleshoot the device tracker(s)"

In English there is no problem, but in other languages that "the" changes for singular and plural.
I also do not immediately understand if "trackers" refers to external devices or built-in routines.
Rewording might help other users, too.

@NoRi2909 NoRi2909 added the bug Something isn't working label Oct 17, 2024
@jpelgrom
Copy link
Member

Device trackers are a core part of Home Assistant, so we won't remove this reference.

@NoRi2909
Copy link
Contributor Author

@jpelgrom But as you wrote "device trackers" you could use plural in the string, too?

Probably just using:
"View a history of location tracking updates to troubleshoot any device trackers"

I was not asking you to remove that entirely …

@jpelgrom
Copy link
Member

You can only troubleshoot the app device tracker so using the singular version here is correct.

@NoRi2909
Copy link
Contributor Author

NoRi2909 commented Oct 17, 2024

@jpelgrom Cool, that completely solves the issue.

Problem was that before I picked up the German translation someone else fully translated that word to

"Geräte-Tracker" (singular in the device_tracker string)
"Geräte-Trackern" (dative, plural)

the latter because of the "with …".

With singular I can translate

"View a history of location tracking updates to troubleshoot the device tracker"

as

"Aktualisierungsverlauf der Standortverfolgung anzeigen, um Probleme mit dem Device Tracker zu beheben"

(keeping the English word so it matches https://www.home-assistant.io/integrations/device_tracker/ )

@NoRi2909
Copy link
Contributor Author

@jpelgrom You could do me one more favor: That "with" below means "together with" or "at the same time", right?

sensor_setting_geocode_include_location_updates_title
"Update sensor with location sensors"

German has so many more words than English that by picking the wrong one of the possible translations you can completely alter the meaning (when there is no context that helps) …

@jpelgrom
Copy link
Member

That "with" below means "together with" or "at the same time", right?

Yes, correct.

No need to keep @ mentioning in issues when there is a single conversation.

@NoRi2909
Copy link
Contributor Author

One last thing you can fix easily along with the stuff above:

The button labels nfc_btn_read_tag and nfc_btn_write_tag tend to become longer in translations. In German this results in the "Write NFC tag" no longer fitting a single line, and no longer being centered:

Companion

I already changed this in Lokalise for the German UI to just "Read tag" and "Write tag", but you might want to make the same change so future translators don't run into the same issue in other languages.

NFC is already mentioned twice on that page so it should be pretty clear what these buttons are about. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants