Mosquitto add-on verbose logging

[b3nj1]

Hi,
The mosquitto logging level has been increased (again). Back in PR #1708, we used the system logging level into the mosquitto logging level, but this has been removed in #2007.

I'd like to submit a PR to address this, but first, @frenck, was the unconfigurable logging level change intentional for some reason. If it was intentional, is there a preferred way to make it configurable over the way we had it below?

New template log level:

addons/mosquitto/rootfs/usr/share/tempio/mosquitto.gtpl

Line 7 in 54ce6a1

log_type information

Old code to set logging level based on configured level:

addons/mosquitto/data/run.sh

Lines 92 to 101 in 107585d

	if [ "${LOGGING}" == "debug" ]; then
	sed -i "s/%%AUTH_QUIET_LOGS%%/false/g" /etc/mosquitto.conf
	else
	sed -i "s/%%AUTH_QUIET_LOGS%%/true/g" /etc/mosquitto.conf
	if [ "${LOGGING}" == "critical" ] || [ "${LOGGING}" == "fatal" ] || [ "${LOGGING}" == "error" ]; then
	sed -i -e "s/^log_type warning//" -e "s/^log_type notice//" -e "s/^log_type information//" /etc/mosquitto.conf
	elif [ "${LOGGING}" == "warning" ] || [ "${LOGGING}" == "warn" ]; then
	sed -i -e "s/^log_type notice//" -e "s/^log_type information//" /etc/mosquitto.conf
	fi
	fi

Thanks,

• Benjamin

[frenck]

There is not need to do that or add such logic. If you want to override settings on that level, the customization feature is available. That would allow you to write about any option to mosquitto.

[b3nj1]

@frenck , the log_type conf is additive, so I believe I can't "remove" the settings that were applied in the add-on's supplied configuration. Do you mind if we remove the log_type settings from the add-on config?

Thanks for the pointer on the customization! It's a nice method in general.

• Benjamin

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.