Mypy performance fix #435
Merged
Mypy performance fix #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinHjelmare
approved these changes
May 29, 2022
|
Small followup now that Home Assistant has been updated to use |
|
excellent, thanks for your help with this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a Union TypeAlias with lots of members can significantly slow down mypy, especially the uncompiled version. Noticed it while testing a mypy dev build with Home Assistant. The CI run took significantly longer,
30+ mincompared to7-8minnormally.The slowdown in HA only happened after the
0.37.0update, since that's whenpy.typedwas added. Previously mypy just ignored the dependency.--
Specifically, the
MultilevelSensorScaleTypealias with 30+ members is a problem. The fix here is relatively simple. We can create a common enum base class and use that instead of the union TypeAlias. The only thing to remember is that no members can be added to the base class directly. Otherwise subclassing enums wouldn't work.