Descendant CSS selector type not supported

[haydenbleasel]

Hi! Wanted to cross-reference a bug I'm investigating in Tiptap: ueberdosis/tiptap#4089

Currently when parsing the following HTML:

<div data-youtube-video>
        <iframe src="https://www.youtube.com/watch?v=cqHqLQgVCgY"></iframe>
</div>

It results in:

Unknown CSS selector type descendant div[data-youtube-video] iframe [
  { type: 'tag', name: 'div', namespace: null },
  {
    type: 'attribute',
    name: 'data-youtube-video',
    action: 'exists',
    value: '',
    namespace: null,
    ignoreCase: null
  },
  { type: 'descendant' },
  { type: 'tag', name: 'iframe', namespace: null }
]

Looks like descendant support is in the code but commented out, either:

1. Here:

   zeed-dom/src/vcss.ts

   Line 103 in 6a2d669

   // } else if (type === 'descendant') {

2. or here:

   zeed-dom/src/vcss.ts

   Line 106 in 6a2d669

   // else if (type === 'descendant') {

I'll keep digging and hopefully open a PR if I can manage to fix it.

[holtwick]

It's true, descendants are currently not supported. It would indeed be nice to have such a feature.

It might require some recursive calls. The code is already prepared quite well for such an extension.

If you could contribute a PR, I would be more than happy to merge it. Thanks.