Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken shared linked crosshair tool if set on one dimension only #6386

Closed
TheoMathurin opened this issue Sep 24, 2024 · 2 comments · Fixed by #6387
Closed

Broken shared linked crosshair tool if set on one dimension only #6386

TheoMathurin opened this issue Sep 24, 2024 · 2 comments · Fixed by #6387
Labels
type: bug Something isn't correct or isn't working

Comments

@TheoMathurin
Copy link
Contributor

TheoMathurin commented Sep 24, 2024

ALL software version info

Software Version Info
holoviews 1.19.1
bokeh 3.5.2
panel 1.15.0

Description of expected behavior and the observed behavior

The update to Bokeh 3.5 breaks shared Crosshair tools seemingly if they're not enabled for both width and height. Separate tools appear separately on each plot.

Complete, minimal, self-contained example code that reproduces the issue

NB: Pure bokeh example from their docs works as expected.

import holoviews as hv
import numpy as np
from bokeh.models import CrosshairTool, Span
import panel as pn

hv.extension("bokeh")

s1 = hv.Scatter(np.random.randn(10, 10))
s2 = hv.Scatter(np.random.randn(10, 10))
s3 = hv.Scatter(np.random.randn(10, 10))
s4 = hv.Scatter(np.random.randn(10, 10))

height = Span(dimension="height")
width = Span(dimension="width")
cht1 = CrosshairTool(overlay=[height, width])
cht2 = CrosshairTool(overlay=height)
s1 = s1.opts(tools=[cht1])
s2 = s2.opts(tools=[cht1])
s3 = s3.opts(tools=[cht2])
s4 = s4.opts(tools=[cht2])

pn.Row(pn.Column(s1, s2), pn.Column(s3, s4)).servable()

Stack traceback and/or browser JavaScript console output

Nothing

Screenshots or screencasts of the bug in action

crosshair

@hoxbro hoxbro added the type: bug Something isn't correct or isn't working label Sep 24, 2024
@hoxbro
Copy link
Member

hoxbro commented Sep 24, 2024

Introduced by #6220

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants