Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify core operation classes #1419

Closed
jlstevens opened this issue May 8, 2017 · 4 comments
Closed

Simplify core operation classes #1419

jlstevens opened this issue May 8, 2017 · 4 comments
Assignees
Milestone

Comments

@jlstevens
Copy link
Contributor

In PR #1391 we finally started documented operations. While doing through this tutorial in #1384, we realized that we hardly ever use anything other than ElementOperation.

MapOperation has never been used to our knowledge and its definition is so light a user might as well just write their own param.ParameterizedFunction. This just leaves TreeOperation which has only been used by the holoviews devs in a few places (in particular, one operation in featuremapper is a tree operation).

My recommendation is as follows:

  • Remove MapOperation entirely
  • Fold the current Operation baseclass into ElementOperation
  • Rename ElementOperation to Operation (a better name for users).
  • Leave a class ElementOperation(Operation): definition just to issue a deprecation warning.
  • Remove TreeOperation, factoring any general and useful functionality into a utility.

This plan maintains backwards compatibility as we never used or documented MapOperation and TreeOperation is very unlikely to be used by users as it is needed for rare, more complex tasks (and was also undocumented).

Having a single Operation base class would simplify things a lot!

@jlstevens jlstevens added this to the v1.7.1 milestone May 8, 2017
@jlstevens
Copy link
Contributor Author

Everything suggested in this issue has been addressed by the PR referenced above (#1421) except for removing TreeOperation.

@philippjfr Happy for me to just remove it from HoloViews and add it to featuremapper?

@jlstevens jlstevens self-assigned this May 18, 2017
@philippjfr
Copy link
Member

Sure, as long as you update the imports in topographica as well.

@jlstevens
Copy link
Contributor Author

The final bit (removing TreeOperation) was merged in the PR above. Closing.

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants