Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated helm charts with separated configmaps for dummy deployments #632

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Updated helm charts with separated configmaps for dummy deployments #632

merged 1 commit into from
Feb 22, 2024

Conversation

wehappyfew
Copy link
Contributor

@wehappyfew wehappyfew commented Feb 22, 2024 •
edited
Loading

Describe Changes

I made this better by doing ...

  • Updated helm charts with separated configmaps for dummy deployments
  • Removed the old env secrets from testnet cicd

Checklist before requesting a review

  • I have performed a self-review of my code
  • Code styles have been enforced
  • I have checked eslint

sogoiii
sogoiii approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@sogoiii sogoiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sogoiii sogoiii merged commit 14aa4f5 into develop Feb 22, 2024
3 checks passed
@sogoiii sogoiii deleted the feat/dummy-configmaps-for-clis-in-separate-ns branch February 22, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sogoiii sogoiii sogoiii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wehappyfew @sogoiii