From 17bb85c1d6da6295726459b31019167798156354 Mon Sep 17 00:00:00 2001 From: Lieven Hollevoet Date: Wed, 7 Nov 2012 10:20:12 +0100 Subject: [PATCH 1/2] Updated gitignore file We should not commit intermediate files, .tmp files or .log files --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index d3e79f92d..466b588e9 100644 --- a/.gitignore +++ b/.gitignore @@ -13,3 +13,6 @@ META.yml MYMETA.yml nytprof.out pm_to_blib +*~ +*.tmp +*.log \ No newline at end of file From 42104f54e000a4cc9d03ba8a820ed0ba87c77541 Mon Sep 17 00:00:00 2001 From: Lieven Hollevoet Date: Wed, 7 Nov 2012 10:46:11 +0100 Subject: [PATCH 2/2] Reverted the change to xPL_Items.pm The device_monitor function was changed in a previous commit to match any characters instead of only non-whitespace characters. This causes some existing xPL device stop funcitoning with MH, as state in #10. What was the reasoning behind this change? I guess it doesn't make sense to make MH restrictive in what messages is can process. IMHO whitespace should not cause a message to fail, as xPL is supposed to be a human-readable format. --- lib/xPL_Items.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/xPL_Items.pm b/lib/xPL_Items.pm index a9aaaf402..88d1cda8e 100644 --- a/lib/xPL_Items.pm +++ b/lib/xPL_Items.pm @@ -1020,7 +1020,7 @@ sub tie_value_convertor { sub device_monitor { my ( $self, $monitor_info ) = @_; if ($monitor_info) { - my ($key,$value) = $monitor_info =~ /(\S+)\s*[:=]\s*(.+)/; + my ($key,$value) = $monitor_info =~ /(\S+)\s*[:=]\s*(\S+)/; if ( !( $value or $value =~ /^0/ ) ) { $value = ($key) ? $key : $monitor_info; $key = 'device';