Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: Tracker mesage is not removed if the check is cancelled #327

Closed
Tracked by #273
georgeciubotaru opened this issue Nov 20, 2024 · 19 comments · Fixed by #330
Closed
Tracked by #273

Problem: Tracker mesage is not removed if the check is cancelled #327

georgeciubotaru opened this issue Nov 20, 2024 · 19 comments · Fixed by #330
Assignees

Comments

@georgeciubotaru
Copy link
Contributor

georgeciubotaru commented Nov 20, 2024

image
@georgeciubotaru
Copy link
Contributor Author

@teodorus-nathaniel Can you please check if that is a bug or a missing feature?

@teodorus-nathaniel
Copy link
Contributor

You mean when the pr title changes to non fix?

is the check itself cancelled, but the message not removed?

@georgeciubotaru
Copy link
Contributor Author

@teodorus-nathaniel Yes

@teodorus-nathaniel
Copy link
Contributor

teodorus-nathaniel commented Nov 21, 2024

Hi @georgeciubotaru is it possible for me to check the production logs?

Actually I'm having some trouble with running the project in my local.
When I setting up a new project, I usually see confirm that the project is setup correctly when I see there is a new run after I register the endpoint
image

But I'm not sure why, I tried making multiple new projects but none of them have any run triggered after I register the endpoint.

Do you know what possibly is the issue? Or how to trigger the webhook registering process manually?

@georgeciubotaru
Copy link
Contributor Author

@teodorus-nathaniel Probably the webhook was removed, please try with different proxy address to register the webhooks

@teodorus-nathaniel
Copy link
Contributor

Yeah I have tried with new proxy addresses, which I was hoping that it will register to github after I have registered the endpoint. But the issue is they didn't trigger the run to register the new proxy address

Is it working well for you?

@georgeciubotaru
Copy link
Contributor Author

Log: I will check on my end

@georgeciubotaru
Copy link
Contributor Author

@teodorus-nathaniel Mine looks that way:
image

But does your telebit proxy URL work?, on my side it doesn't work

@teodorus-nathaniel
Copy link
Contributor

@georgeciubotaru that telebit url was just a dummy from readme, the issue is that in my case, there is no run at all after the url register

so everything works well on your side? if thats the case ill try it again from the start

btw thanks for checking it out

@georgeciubotaru
Copy link
Contributor Author

@teodorus-nathaniel The URL you are seeing is used by me locally.

@teodorus-nathaniel
Copy link
Contributor

teodorus-nathaniel commented Nov 22, 2024

@teodorus-nathaniel The URL you are seeing is used by me locally.

@georgeciubotaru yes for the url that I meant dummy was this image that I sent before.
image

I just tried again using same flow as yesterday, but now I see the run 😅
So its looking all good now, thank you, will resume checking this issue up

@teodorus-nathaniel
Copy link
Contributor

teodorus-nathaniel commented Nov 22, 2024

@georgeciubotaru sorry I just realized, now its getting weirder,
now it have 1 run after registering the url, but its really strange that its using your local telebit url 😓,

I have never copied your telebit url though, so I'm really not sure why is it like that.
Could you check out the steps I did in the video below and maybe see where the problem is?

2024-11-22.20-16-02.mp4

By the way, I have tried twice with different projects and got same issue

@georgeciubotaru
Copy link
Contributor Author

georgeciubotaru commented Nov 22, 2024

@teodorus-nathaniel I can see you are using a custom project, did you also update the package.json file?

image

@teodorus-nathaniel
Copy link
Contributor

@teodorus-nathaniel I can see you are using a custom project, did you also update the package.json file?

image

yesterday I think I have tried to change that one too but no runs, but for the one just now, no I haven't change it
ill try it now

@teodorus-nathaniel
Copy link
Contributor

teodorus-nathaniel commented Nov 22, 2024

@georgeciubotaru I have tried twice

First one, I updated the project in package json after I run the docker compose up, result: using your telebit url

2024-11-22.20-40-00.mp4

Second one, I created the project beforehand, deleted and restarted the docker, and run the steps, result: no trigger being ran

2024-11-22.20-47-32.mp4

@teodorus-nathaniel
Copy link
Contributor

teodorus-nathaniel commented Nov 22, 2024

@georgeciubotaru finally its good now, so the trick maybe have to do with the package json projectId,
If the projectId there is changed, the docker needs to be restarted

But I don't know why the one I did above didn't work, maybe because its the domain that I have used before
I'll try some more times, and if its the correct issue, then Ill add the readme for this case

2024-11-22.20-58-48.mp4

@teodorus-nathaniel
Copy link
Contributor

@georgeciubotaru I also would like to ask again about the "bug commit link" that will be submitted by the user
which link will the users submit:

  • https://github.com/holdex/pr-time-tracker/commit/2ea61cd0e9808060cd73d6e169f5a9d6acb14460
  • https://github.com/holdex/pr-time-tracker/pull/322/commits/8cccee5e9da414d3a722dc0ca8cbc50b24339bf6

First one, I can get it more easily, by:

  1. Get which commit causes the bug (I use gitlens)
    image
  2. Get commit link to github
    image

Second one:

  1. Get which commit causes the bug (I use gitlens) and open the PR link
    image
  2. Find the commit that causes the bug from the PR (its hard to check one by one, so maybe copy any commit, but its not really logically make sense, but its okay as the commit hash itself is not sent to bigquery)
    image

After I think again, I think it should be the first link right?
Right now I am parsing the link with 2nd format though, so if we wanna use the first format, I need to create a new issue for it.

@georgeciubotaru
Copy link
Contributor Author

@teodorus-nathaniel Second option

@teodorus-nathaniel
Copy link
Contributor

ah okay in that case, I have made the correct handler, thank you 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants