-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: Tracker doesn't store bug info in DB #320
Comments
@georgeciubotaru for this problem, I'm thinking of storing this in DB only when the PR is merged |
@teodorus-nathaniel This should be the event of adding the bug information via comment, and should be inserted in the Bigquery DB. The action should happen only when it is added |
I'm thinking of saving it when its closed because, if we insert it before the close, there may be too many case we need to catch:
that's why I'm thinking of just adding the data to db after its closed, where it's the finalized comment |
@teodorus-nathaniel Kinda complicated, but we should run this only if the PR is marked for review, until that let's not display anything. Let's do the simple case, then we can try more complicated ones |
@georgeciubotaru just to confirm, we should still insert to db when the user inserted the comment instead of when the PR merged right? but what's the concern of inserting the data to DB when the PR is merged? it seems simpler flow to manage for me |
@teodorus-nathaniel You can go your way, the result: we should see the bug_introduced events in the Bigquery |
@georgeciubotaru if I send events to BigQuery and save the data to DB, will this also resolves #321 ? |
@teodorus-nathaniel we need bug info only in Bigquery, not in the DB.
Yes |
In that case, Ill close this issue then, we have the BigQuery related problem in #321 |
Sub of
The text was updated successfully, but these errors were encountered: