Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: Tracker doesn't store bug info in DB #320

Closed
Tracked by #273
teodorus-nathaniel opened this issue Nov 13, 2024 · 9 comments
Closed
Tracked by #273

Problem: Tracker doesn't store bug info in DB #320

teodorus-nathaniel opened this issue Nov 13, 2024 · 9 comments
Assignees

Comments

@teodorus-nathaniel
Copy link
Contributor

Sub of

@teodorus-nathaniel
Copy link
Contributor Author

teodorus-nathaniel commented Nov 14, 2024

@georgeciubotaru for this problem, I'm thinking of storing this in DB only when the PR is merged
wdyt?

@teodorus-nathaniel teodorus-nathaniel self-assigned this Nov 14, 2024
@georgeciubotaru
Copy link
Contributor

@teodorus-nathaniel This should be the event of adding the bug information via comment, and should be inserted in the Bigquery DB. The action should happen only when it is added

@teodorus-nathaniel
Copy link
Contributor Author

I'm thinking of saving it when its closed because, if we insert it before the close, there may be too many case we need to catch:

  • PR changed to non fix:, remove the data
  • The report comment edited: edit the data
  • The report comment deleted: delete the data

that's why I'm thinking of just adding the data to db after its closed, where it's the finalized comment

@georgeciubotaru
Copy link
Contributor

@teodorus-nathaniel Kinda complicated, but we should run this only if the PR is marked for review, until that let's not display anything.
Basically, altering the comment or title are edge cases and we can fix them in future iterations if that will be the case.

Let's do the simple case, then we can try more complicated ones

@teodorus-nathaniel
Copy link
Contributor Author

teodorus-nathaniel commented Nov 14, 2024

@georgeciubotaru just to confirm, we should still insert to db when the user inserted the comment instead of when the PR merged right?

but what's the concern of inserting the data to DB when the PR is merged? it seems simpler flow to manage for me

@georgeciubotaru
Copy link
Contributor

@teodorus-nathaniel You can go your way, the result: we should see the bug_introduced events in the Bigquery

@teodorus-nathaniel
Copy link
Contributor Author

@georgeciubotaru if I send events to BigQuery and save the data to DB, will this also resolves #321 ?

@georgeciubotaru
Copy link
Contributor

@teodorus-nathaniel we need bug info only in Bigquery, not in the DB.

will this also resolves #321 ?

Yes

@teodorus-nathaniel
Copy link
Contributor Author

@teodorus-nathaniel we need bug info only in Bigquery, not in the DB.

In that case, Ill close this issue then, we have the BigQuery related problem in #321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants