Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: it is not clear when CI is triggered #266

Open
Tracked by #259
zolotokrylin opened this issue Jun 24, 2024 · 4 comments
Open
Tracked by #259

Problem: it is not clear when CI is triggered #266

zolotokrylin opened this issue Jun 24, 2024 · 4 comments
Assignees
Labels
type: bug Something isn't working

Comments

@zolotokrylin
Copy link
Member

zolotokrylin commented Jun 24, 2024

https://github.com/clearpool-finance/clearpool.finance/pull/2759

there is no option to submit PR cost. CI was not triggered at all

sub of:

@zolotokrylin zolotokrylin added the type: bug Something isn't working label Jun 24, 2024
@georgeciubotaru
Copy link
Contributor

@zolotokrylin

  1. You haven't requested a review
  2. You cannot submit PR cost after it is merged
  3. Haven't used the draft -> ready for review

@zolotokrylin
Copy link
Member Author

zolotokrylin commented Jun 24, 2024

“2.” Is ok condition, but why 1 and 3?
When I open none draft, it's already review requested, no?

@georgeciubotaru

@georgeciubotaru
Copy link
Contributor

  1. We defined specs to explicitly request review (it's not the same as marking as ready for review)
  2. We requesting other devs to follow that flow.

You need to explicitly request a review otherwise you cannot submit the cost.
If you don't need approvals for your PR then just assign someone as a reviewer, submit your cost, and merge the PR.

@zolotokrylin
Copy link
Member Author

OK. Can you then explain it in README, because I don't know when it is working and when it is not working because the settings are very diversified?

@zolotokrylin zolotokrylin changed the title Bug: I was not requested to submit PR cost Problem: it is not clear when CI is triggered Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants