Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 - Either match ESPAsyncWS method names or provide a migration path (compile flag ?) #151

Open
hoeken opened this issue Aug 11, 2024 · 0 comments · May be fixed by #115
Open

v2 - Either match ESPAsyncWS method names or provide a migration path (compile flag ?) #151

hoeken opened this issue Aug 11, 2024 · 0 comments · May be fixed by #115
Assignees

Comments

@hoeken
Copy link
Owner

hoeken commented Aug 11, 2024

proposal from @mathieucarbou

send vs reply:

#ifdef PSYCHIC_TO_ESPASYNCWS
    esp_err_t send(int code) { return reply(code); }
    esp_err_t send(int code, const String& contentType = emptyString, const String& content = emptyString);
#endif

constructor:

PsychicHttpServer(uint16_t port = 80);

begin / end vs listen / stop:

#ifdef PSYCHIC_TO_ESPASYNCWS
    void begin(uint16_t port = 80) { listen(port); }
    void end() { stop(); }
#endif

etc...

@mathieucarbou mathieucarbou self-assigned this Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants