Skip to content
This repository has been archived by the owner on Sep 20, 2021. It is now read-only.

Replace hard coded value by constant #28

Open
vonglasow opened this issue Aug 28, 2015 · 1 comment
Open

Replace hard coded value by constant #28

vonglasow opened this issue Aug 28, 2015 · 1 comment

Comments

@vonglasow
Copy link
Member

vonglasow commented Aug 28, 2015

https://github.com/hoaproject/Mail/pull/27/files#diff-b518b20b529a6cf4ff44c6fba63eee4fR273

In this code, we use a lot a hard coded value which represent smtp return code and other stuff. This is not so explicit it could be better to have a constant related.

What do you think?


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@Hywan
Copy link
Member

Hywan commented Aug 28, 2015

Hello :-),

As said on IRC: “This is just codes, this is hard to associate a name to them”. But we can try by re-reading all the RFCs, thoughts?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants