Support strict_types=1 for overridden functions #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #43.
I'm simply copying the parameter parsing from official php source https://github.com/php/php-src/blob/e219ec144ef6682b71e135fd18654ee1bb4676b4/ext/date/php_date.c as it appears the strict_type checking occurs inside the
Z_PARAM_STR()
/ZEND_PARSE_PARAMETERS_END_EX()
macros. I left the original php-source names, which is why they're a little inconsistent (heh).As this is effectively parsing the parameters an additional time, it comes with a very slight performance hit, but I figure that's totally acceptable for a testing library if it means more correctness.