Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Bump sshpk from 1.13.1 to 1.16.1 #141

Merged
merged 1 commit into from
Jan 28, 2019

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Jan 24, 2019

Bumps sshpk from 1.13.1 to 1.16.1. This update includes security fixes.

Vulnerabilities fixed

Sourced from The npm Advisory Database.

Regular Expression Denial of Service
Versions of sshpk before 1.13.2 or 1.14.1 are vulnerable to regular expression denial of service when parsing crafted invalid public keys.

Affected versions: <1.13.2; >=1.14.0 <1.14.1

Sourced from The GitHub Security Advisory Database.

Moderate severity vulnerability that affects sshpk
The sshpk NPM package is vulnerable to ReDoS when parsing crafted invalid public keys.

Affected versions: < 1.13.2

Sourced from The Node Security Working Group.

Denial of Service
sshpk is vulnerable to ReDoS when parsing crafted invalid public keys

Affected versions: <=1.13.1

Release notes

Sourced from sshpk's releases.

v1.16.0

  • Add support for SPKI fingerprints, PuTTY PPK format (public-key only for now), PKCS#8 PBKDF2 encrypted private keys
  • Fix for #48

v1.15.2

  • New API for accessing x509 extensions in certificates
  • Fixes for #52, #50

v1.14.1

  • Remove all remaining usage of jodid25519 (abandoned dep)
  • Add support for DNSSEC key format
  • Add support for Ed25519 keys in PEM format (according to draft-curdle-pkix)
  • Fixes for X.509 encoding issues (asn.1 NULLs in RSA certs, cert string type mangling)
  • Performance issues parsing long SSH public keys
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@dependabot-preview dependabot-preview bot added dependencies minor A minor dependency version bump security Pull requests that address a security vulnerability labels Jan 24, 2019
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview January 24, 2019 06:17 Inactive
@codecov
Copy link

codecov bot commented Jan 24, 2019

Codecov Report

Merging #141 into master will increase coverage by 2.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
+ Coverage    85.1%   87.19%   +2.08%     
==========================================
  Files          34       34              
  Lines         638      695      +57     
  Branches       65       83      +18     
==========================================
+ Hits          543      606      +63     
+ Misses         64       61       -3     
+ Partials       31       28       -3
Impacted Files Coverage Δ
src/main/routes/home.ts 73.91% <0%> (-2.28%) ⬇️
src/main/routes/createUser.ts 76.31% <0%> (-0.16%) ⬇️
src/main/service/delete-user-service.ts 100% <0%> (ø) ⬆️
src/main/validators/validateUserProfile.ts 100% <0%> (ø) ⬆️
src/main/service/get-service.ts 100% <0%> (ø) ⬆️
src/main/user/auth-checker-user-only-filter.ts 100% <0%> (ø) ⬆️
src/main/service/create-user-service.ts 100% <0%> (ø) ⬆️
src/main/service/service-token-generator.ts 100% <0%> (ø) ⬆️
src/main/routes/userProfiles.ts 100% <0%> (ø) ⬆️
src/main/service/create-definition-service.ts 100% <0%> (ø) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1ca00e...cc8d57d. Read the comment docs.

@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview January 26, 2019 16:34 Inactive
@dwaynebailey
Copy link
Contributor

@dependabot-bot rebase

Bumps [sshpk](https://github.com/joyent/node-sshpk) from 1.13.1 to 1.16.1. **This update includes security fixes.**
- [Release notes](https://github.com/joyent/node-sshpk/releases)
- [Commits](TritonDataCenter/node-sshpk@v1.13.1...v1.16.1)

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/sshpk-1.16.1 branch from 17cd878 to cc8d57d Compare January 28, 2019 12:07
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview January 28, 2019 12:15 Inactive
@codecov-io
Copy link

codecov-io commented Jan 28, 2019

Codecov Report

Merging #141 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #141   +/-   ##
=======================================
  Coverage   87.19%   87.19%           
=======================================
  Files          34       34           
  Lines         695      695           
  Branches       83       83           
=======================================
  Hits          606      606           
  Misses         61       61           
  Partials       28       28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1ca00e...cc8d57d. Read the comment docs.

@dwaynebailey dwaynebailey merged commit d29f0e4 into master Jan 28, 2019
@dwaynebailey dwaynebailey deleted the dependabot/npm_and_yarn/sshpk-1.16.1 branch January 28, 2019 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies minor A minor dependency version bump security Pull requests that address a security vulnerability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants