Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The title of the valueset is misspelled and its ID does not follow the DK Core convention #108

Closed
jkiddo opened this issue Nov 30, 2023 · 2 comments
Closed

The title of the valueset is misspelled and its ID does not follow the DK Core convention #108

jkiddo opened this issue Nov 30, 2023 · 2 comments
Assignees
@tmsMedcom
Labels
bug Something isn't working
Milestone
3.0.0

Comments

@jkiddo
Copy link
Collaborator

jkiddo commented Nov 30, 2023

dk-core/input/fsh/valueSets.fsh

Line 37 in 325453f

ValueSet: TechniqesSCTCodes

@jkiddo jkiddo added the bug Something isn't working label Nov 30, 2023
@jkiddo
Copy link
Collaborator Author

jkiddo commented Nov 30, 2023

It should probably have been

ValueSet: TechniquesSCTCodes
Title: "TechniquesSCTCodes"
Id: dk-core-TechniquesSCTCodes

@jkiddo
Copy link
Collaborator Author

jkiddo commented Nov 30, 2023

or even skip the title as it brings no extra value in its current form

@tmsMedcom tmsMedcom added this to the 3.0.0 milestone Nov 30, 2023
tmsMedcom added a commit that referenced this issue Nov 30, 2023
@tmsMedcom
Corrected misspelling in TechniquesSCTCodes
b37ec68 
#108
@tmsMedcom tmsMedcom mentioned this issue Nov 30, 2023
Merged
jkiddo pushed a commit that referenced this issue Dec 1, 2023
@tmsMedcom
Corrected misspelling in TechniquesSCTCodes (#109)
4c9a89f 
#108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmsMedcom tmsMedcom

Labels
bug Something isn't working
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@jkiddo @tmsMedcom