-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
About Page added #10
About Page added #10
Conversation
@hkasera Please review the PR. We will be applying for RGSoC 2016 and want to contribute to this project. |
@@ -0,0 +1,41 @@ | |||
<!doctype html> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for formatting the file! 👍
Please make the changes as commented 😃 |
Suggested changes made. |
How did you test this code? |
We didn't test our code against specific test-cases as such. We simply checked for the output corresponding to the changes made (as it is front-end part). |
Testing a front end code involves testing in various browsers and in various resolutions. You should check if your UI looks the same across all latest browser versions. HTML validator is a good source to catch unintentional errors. |
@prachiagrawal269 Why did you reopen this? Have you made any changes in this PR? |
I closed it by mistake. No further changes have been made after that. |
Please fix the issues and let me know or else mention if you are not working on it :) |
@hkasera Sorry, but we are not working on this issue any more. |
Sure, I will close the PR in that case :) On Tue, Apr 12, 2016 at 2:07 PM, Prachi Agrawal [email protected]
|
fixed #7
We have created the about page for the website.
@hkasera Kindly review the pull request
![screenshot from 2016-03-31 19 50 35](https://cloud.githubusercontent.com/assets/9863912/14178857/24e1493e-f77a-11e5-8b5b-5a0397299e73.png)
Attached screen shot of the same: