Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About Page added #10

Closed
wants to merge 3 commits into from

Conversation

prachiagrawal269
Copy link

fixed #7
We have created the about page for the website.

@hkasera Kindly review the pull request
Attached screen shot of the same:
screenshot from 2016-03-31 19 50 35

@prachiagrawal269
Copy link
Author

@hkasera Please review the PR. We will be applying for RGSoC 2016 and want to contribute to this project.
Thank you

@hkasera hkasera added the testing label Apr 5, 2016
@@ -0,0 +1,41 @@
<!doctype html>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for formatting the file! 👍

@hkasera
Copy link
Owner

hkasera commented Apr 8, 2016

Please make the changes as commented 😃

@prachiagrawal269
Copy link
Author

Suggested changes made.
Thanks for the suggestions.

@hkasera
Copy link
Owner

hkasera commented Apr 8, 2016

How did you test this code?

@prachiagrawal269
Copy link
Author

We didn't test our code against specific test-cases as such. We simply checked for the output corresponding to the changes made (as it is front-end part).
Are you referring to "HTML validator" or is there any specified testing framework to test our code?

@hkasera
Copy link
Owner

hkasera commented Apr 8, 2016

Testing a front end code involves testing in various browsers and in various resolutions. You should check if your UI looks the same across all latest browser versions. HTML validator is a good source to catch unintentional errors.

@hkasera
Copy link
Owner

hkasera commented Apr 8, 2016

@prachiagrawal269 Why did you reopen this? Have you made any changes in this PR?

@prachiagrawal269
Copy link
Author

I closed it by mistake. No further changes have been made after that.

@hkasera
Copy link
Owner

hkasera commented Apr 12, 2016

Please fix the issues and let me know or else mention if you are not working on it :)

@prachiagrawal269
Copy link
Author

@hkasera Sorry, but we are not working on this issue any more.

@hkasera
Copy link
Owner

hkasera commented Apr 12, 2016

Sure, I will close the PR in that case :)

On Tue, Apr 12, 2016 at 2:07 PM, Prachi Agrawal [email protected]
wrote:

@hkasera https://github.com/hkasera Sorry, but we are not working on
this issue any more.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#10 (comment)

@hkasera hkasera closed this Apr 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About Page for the website
2 participants