Skip to content
This repository has been archived by the owner on Aug 4, 2020. It is now read-only.

(Possibly) charset related issue in test coverage check #18

Open
fuglede opened this issue Jan 1, 2016 · 3 comments
Open

(Possibly) charset related issue in test coverage check #18

fuglede opened this issue Jan 1, 2016 · 3 comments

Comments

@fuglede
Copy link

fuglede commented Jan 1, 2016

This Travis build, called from EFForg/https-everywhere#3726, triggers an error which shouldn't really be triggered.

@fuglede fuglede changed the title Charset related issue in test coverage check (Possibly) charset related issue in test coverage check Jan 1, 2016
@hiviah
Copy link
Owner

hiviah commented Jan 4, 2016

It seems that the code is matching Unicode regex against IDNA-encoded domain/URL. Unfortunately, that can't be done (cleanly at least), because urlparse/urlunparse does not work with regexps. In the same manner, IDNA-encoding a regexp does not have the result you want, e.g.:

"^http://bernina-zürich\.ch/".decode("utf8").encode("idna") gives xn--^http://bernina-zrich\\-8lc.ch/

I didn't write the code for the test coverage and if you don't need them, just disable them by setting check_coverage to false (it's false by default).

I'll change the sample config for the coverage tests to be turned off (as it should be).

@J0WI
Copy link

J0WI commented Mar 9, 2016

I still run in this issue. Is there any chance to get a fix for this or something I where I could help?

@hiviah
Copy link
Owner

hiviah commented Mar 22, 2016

Sorry, but what this project would need most is a new maintainer. Since I started a new job I probably won't find time for this, it seems.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants