Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFT Properties not update on the market #67

Open
Rishi556 opened this issue May 11, 2021 · 2 comments
Open

NFT Properties not update on the market #67

Rishi556 opened this issue May 11, 2021 · 2 comments

Comments

@Rishi556
Copy link

If a NFT is placed for sale, then its properties are edited, when getting the order book, the updated grouping of the card isn't shown. Instead the old one is.

@CADawg
Copy link

CADawg commented May 11, 2021

This is an issue. It makes grouping items on markets impossible and ruins the standardised loading system for card images if you use their type and name to sort them.

I would appreciate this being fixed.

@bt-cryptomancer
Copy link
Collaborator

This is more of an NFT design consideration for NFT creators to take into account. Data properties used to define market groupings should be considered read-only while an item is on the market. This is one of the important points noted in the NFT documentation here:

https://github.com/hive-engine/steemsmartcontracts-wiki/blob/master/NFT-Market-Contract.md#setgroupby

image

Perhaps at some point we can look at enforcing the use of read-only data properties for this, but I consider it a low priority for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants