Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIKE][download-requirements] Add manifest handling for downloading only needed data #3071

Closed
1 of 5 tasks
sbbroot opened this issue Apr 8, 2022 · 7 comments
Closed
1 of 5 tasks
Assignees

Comments

@sbbroot
Copy link
Contributor

sbbroot commented Apr 8, 2022

Is your spike related to a problem or idea? Please describe.
By default download-requirements should download all the data defined in the requirements files.
If manifest file is provided for the download-requirements script, it should parse it and choose the only needed data for target cluster.

Describe the outcome you'd like
Separate issues should be created for implementing:

  • handling the manifest file
  • dashboards download
  • files download
  • images download
  • packages download
    With full description on how to implement the solution

What is the reason or source for the spike
This is a long wanted feature for the download-requirements script to work much faster.

Additional context


DoD checklist

  • Reader is able to understand the results of spike
  • The results of the spike are presented in a table (to show simply what are compared or researched parameters) / not applicable
  • Each value / cell in the results table is described more deeply below
  • Demo of the spike (automated as much as possible)
  • Design doc updated
@sbbroot
Copy link
Contributor Author

sbbroot commented Apr 21, 2022

Separate SPIKE was added for the packages (#3094)

@sbbroot
Copy link
Contributor Author

sbbroot commented Apr 22, 2022

Issue regarding the manifest was created (#3097)

@sbbroot
Copy link
Contributor Author

sbbroot commented Apr 28, 2022

images - (#3106)
files - (#3116)

@sbbroot
Copy link
Contributor Author

sbbroot commented Apr 28, 2022

dashboards - no need for optimization since downloading all of them takes roughly 2 - 5 seconds:
image.png

@to-bar
Copy link
Contributor

to-bar commented Apr 28, 2022

dashboards - no need for optimization since downloading all of them takes roughly 2 - 5 seconds

I would opt for adding the adaptive functionality also for dashboards but in this case not because of speed but for scenario when a dashboard's URL is broken and user doesn't want to deploy Grafana. Having adaptive mode for dashboards would allow to deploy a cluster successfully despite the broken link(s).

@sbbroot
Copy link
Contributor Author

sbbroot commented Apr 28, 2022

I agree that dashboards should not be downloaded when Grafana is not on a list of components that will be used. As for URLs there is a separate issue on adding alternative URLs.

@sbbroot
Copy link
Contributor Author

sbbroot commented May 6, 2022

Added issue for Grafana dashboards: (#3131).

@seriva seriva closed this as completed May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants