Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Need special deal with azure subscription name if it has slash #2001

Closed
sunshine69 opened this issue Jan 28, 2021 · 1 comment
Closed

Comments

@sunshine69
Copy link
Contributor

sunshine69 commented Jan 28, 2021

Describe the bug
If you subscription name has a slash and even you set it in your service principal yaml epicli will fail at terraform stage.

The problems coming from Azure API itlself, while it allows to use slash / in the subscription name however the endpoint URI will not respect that. PLease see the comment in the PR for more information.

PR included (or a suggestion of the fix)

#2000

What I found is that even I use the subscription ID in the sp.yaml in epiphany after load the yaml it converts it back to the subscription name. So add the logic if the name has / then we set the TF env var to use the ID.

This PR has been working in my test which fix out issue.

@seriva
Copy link
Collaborator

seriva commented Dec 30, 2021

Closing as per comment left on discussion for #2000.

@seriva seriva closed this as completed Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants