Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong stories width calculation making 100% width stories not centered #765

Closed
wants to merge 1 commit into from

Conversation

Mobyrr
Copy link
Contributor

@Mobyrr Mobyrr commented Oct 23, 2024

Description

fix stories with a width of 100% not leaving a gap of 16px at the right

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • If it's a new feature, provide a convincing reason to add it. Ideally, you should open a suggestion issue first and have it approved before working on it.
  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

stackblitz bot commented Oct 23, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codesandbox bot commented Oct 23, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for histoire-examples-svelte3 failed.

Name Link
🔨 Latest commit 4f2c7b0
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-svelte3/deploys/6718eb61ea580e0009c6d279

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for histoire-site failed.

Name Link
🔨 Latest commit 4f2c7b0
🔍 Latest deploy log https://app.netlify.com/sites/histoire-site/deploys/6718eb6133099800086869d8

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for histoire-examples-vue3 failed.

Name Link
🔨 Latest commit 4f2c7b0
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-vue3/deploys/6718eb6135e15600093be887

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for histoire-controls failed.

Name Link
🔨 Latest commit 4f2c7b0
🔍 Latest deploy log https://app.netlify.com/sites/histoire-controls/deploys/6718eb6135e15600093be885

@Mobyrr Mobyrr changed the title fix wrong stories width calculation making 100% width stories not centered fix: wrong stories width calculation making 100% width stories not centered Oct 23, 2024
Copy link

pkg-pr-new bot commented Oct 23, 2024

Open in Stackblitz

histoire

pnpm add https://pkg.pr.new/histoire-dev/histoire@765

@histoire/app

pnpm add https://pkg.pr.new/histoire-dev/histoire/@histoire/app@765

@histoire/controls

pnpm add https://pkg.pr.new/histoire-dev/histoire/@histoire/controls@765

@histoire/plugin-nuxt

pnpm add https://pkg.pr.new/histoire-dev/histoire/@histoire/plugin-nuxt@765

@histoire/plugin-screenshot

pnpm add https://pkg.pr.new/histoire-dev/histoire/@histoire/plugin-screenshot@765

@histoire/plugin-percy

pnpm add https://pkg.pr.new/histoire-dev/histoire/@histoire/plugin-percy@765

@histoire/plugin-svelte

pnpm add https://pkg.pr.new/histoire-dev/histoire/@histoire/plugin-svelte@765

@histoire/plugin-vue

pnpm add https://pkg.pr.new/histoire-dev/histoire/@histoire/plugin-vue@765

@histoire/plugin-vue2

pnpm add https://pkg.pr.new/histoire-dev/histoire/@histoire/plugin-vue2@765

@histoire/shared

pnpm add https://pkg.pr.new/histoire-dev/histoire/@histoire/shared@765

@histoire/vendors

pnpm add https://pkg.pr.new/histoire-dev/histoire/@histoire/vendors@765

commit: 4f2c7b0

@Mobyrr
Copy link
Contributor Author

Mobyrr commented Oct 24, 2024

can be improved, it's not the only thing wrong in this file

@Mobyrr Mobyrr closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant