Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(histoire controls): downgrade vue to make tests pass #581

Closed
wants to merge 1 commit into from

Conversation

czondi
Copy link
Contributor

@czondi czondi commented Aug 15, 2023

Description

Tests fail in packages/histoire-controls with [email protected], but not with [email protected].

Additional context

Tests run with 3.3.4.

packages/histoire-controls test:  FAIL  HstCheckbox › toggle to checked (14.97ms)
packages/histoire-controls test: TypeError: Cannot read properties of undefined (reading '0')
packages/histoire-controls test:     at Object.handler (/Users/x/histoire/packages/histoire-controls/src/components/checkbox/HstCheckbox.spec.ts:14:48)
packages/histoire-controls test: ┌───────────────────────────────┐
packages/histoire-controls test: │ Summary of 1 / 2 failed tests │
packages/histoire-controls test: └───────────────────────────────┘
packages/histoire-controls test:  FAIL  HstCheckbox › toggle to checked
packages/histoire-controls test: TypeError: Cannot read properties of undefined (reading '0')
packages/histoire-controls test:     at Object.handler (/Users/x/histoire/packages/histoire-controls/src/components/checkbox/HstCheckbox.spec.ts:14:48)
packages/histoire-controls test:     at runSuite (file:///Users/x/histoire/node_modules/.pnpm/@[email protected]_@[email protected]/node_modules/@peeky/runner/dist/runtime/run-tests.js:40:21)
packages/histoire-controls test:     at runSuite (file:///Users/x/histoire/node_modules/.pnpm/@[email protected]_@[email protected]/node_modules/@peeky/runner/dist/runtime/run-tests.js:26:17)
packages/histoire-controls test:     at runTests (file:///Users/x/histoire/node_modules/.pnpm/@[email protected]_@[email protected]/node_modules/@peeky/runner/dist/runtime/run-tests.js:8:9)
packages/histoire-controls test:     at runTestFile (file:///Users/x/histoire/node_modules/.pnpm/@[email protected]_@[email protected]/node_modules/@peeky/runner/dist/runtime/run-test-file.js:133:9)
packages/histoire-controls test:     at file:///Users/x/histoire/node_modules/.pnpm/[email protected]/node_modules/tinypool/dist/esm/worker.js:109:20
packages/histoire-controls test: ┌────────────────────────────┐
packages/histoire-controls test: │ Ran 1 tests files (1024ms) │
packages/histoire-controls test: └────────────────────────────┘
packages/histoire-controls test:      Suites 1 / 2
packages/histoire-controls test:       Tests 1 / 2
packages/histoire-controls test:   Snapshots 1 / 1
packages/histoire-controls test:      Errors 1
packages/histoire-controls test: Failed

Tests run with 3.3.3.

packages/histoire-controls test: ┌───────────────────────────┐
packages/histoire-controls test: │ Ran 1 tests files (972ms) │
packages/histoire-controls test: └───────────────────────────┘
packages/histoire-controls test:      Suites 2 / 2
packages/histoire-controls test:       Tests 2 / 2
packages/histoire-controls test:   Snapshots 2 / 2
packages/histoire-controls test:      Errors 0
packages/histoire-controls test: Done

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • If it's a new feature, provide a convincing reason to add it. Ideally, you should open a suggestion issue first and have it approved before working on it.
  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Aug 15, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@codesandbox
Copy link

codesandbox bot commented Aug 15, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@netlify
Copy link

netlify bot commented Aug 15, 2023

Deploy Preview for histoire-examples-svelte3 ready!

Name Link
🔨 Latest commit a6369aa
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-svelte3/deploys/64dbcacef0c45000082ac2d2
😎 Deploy Preview https://deploy-preview-581--histoire-examples-svelte3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 15, 2023

Deploy Preview for histoire-site ready!

Name Link
🔨 Latest commit a6369aa
🔍 Latest deploy log https://app.netlify.com/sites/histoire-site/deploys/64dbcace4a8e490008d9e47b
😎 Deploy Preview https://deploy-preview-581--histoire-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 15, 2023

Deploy Preview for histoire-examples-vue3 ready!

Name Link
🔨 Latest commit a6369aa
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-vue3/deploys/64dbcace07b3d800075c8a57
😎 Deploy Preview https://deploy-preview-581--histoire-examples-vue3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 15, 2023

Deploy Preview for histoire-controls ready!

Name Link
🔨 Latest commit a6369aa
🔍 Latest deploy log https://app.netlify.com/sites/histoire-controls/deploys/64dbcace7733490008682508
😎 Deploy Preview https://deploy-preview-581--histoire-controls.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@czondi czondi closed this Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant