Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dicoding logo #7

Merged
merged 7 commits into from
Oct 11, 2024
Merged

feat: add dicoding logo #7

merged 7 commits into from
Oct 11, 2024

Conversation

interstellardeer
Copy link
Contributor

@interstellardeer interstellardeer commented Oct 11, 2024

Jenis PR (centang semua yang berlaku)

  • Fitur Baru
  • Refaktor
  • Perbaikan Bug
  • Optimasi
  • Pembaruan Dokumentasi

Deskripsi

  • Saya menambahkan fitur baru
  • Saya memperbaiki fitur yang sudah ada
  • Saya memperbaiki bug
  • Saya melakukan optimasi
  • Saya menambah dokumentasi
  • Saya memperbaiki dokumentasi

Terkait Tiket & Dokumen

  • Terkait Isu #
  • Menutup #

Pengujian

Beberapa pengujian akan dilakukan otomatis dengan GitHub Actions saat pull request dibuat

  • Tes linting eslint npm run lint || bun run lint
  • Pesan commit sesuai Conventional Commits npm run commitlint || bun run commitlint
  • Build lokal npm run build || bun run build

Checklist Aksesibilitas UI

Jika PR Anda menyertakan perubahan UI, silakan ceklis daftar berikut ini:

  • HTML Semantik diterapkan?
  • Kontras warna diuji?

Untuk informasi lebih lanjut, cek tautan berikut: Forem Accessibility Docs.

Lingkungan Pengembangan

Saya menggunakan:

Misal: tuliskan hanya "Windows" jika Anda menggunakan Windows

  • os = linux / windows / macOS

@DikDns DikDns changed the title fix: add new logos feat: add dicoding logo Oct 11, 2024
@DikDns DikDns merged commit 4236940 into himarplupi:main Oct 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants