Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BigInt support #80

Closed
hildjj opened this issue Jul 20, 2018 · 6 comments · Fixed by #81
Closed

Add BigInt support #80

hildjj opened this issue Jul 20, 2018 · 6 comments · Fixed by #81
Assignees

Comments

@hildjj
Copy link
Owner

hildjj commented Jul 20, 2018

Node 10.7 implements BigInt

@hildjj
Copy link
Owner Author

hildjj commented Jul 20, 2018

I'd like someone else to review this if possible, please.

@hildjj hildjj closed this as completed in #81 Aug 9, 2018
@cbettinger
Copy link

Is there any way to tell cbor to use BigNumber again on platforms that do not support BigInt?

@hildjj
Copy link
Owner Author

hildjj commented Sep 27, 2021

No. There are a few options you could take:

@hildjj
Copy link
Owner Author

hildjj commented Sep 27, 2021

@cbettinger
Copy link

Thank you very much for your research!

@hildjj
Copy link
Owner Author

hildjj commented Sep 28, 2021

@cbettinger I've added a cbor-rn-prereqs package that should a) make this easier for others, and b) ensure the code we came up with is tested. I updated https://github.com/hildjj/node-cbor-expo-example to use it. See https://github.com/hildjj/node-cbor/tree/main/packages/cbor-rn-prereqs for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants