Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSC Build #195

Closed
louis49 opened this issue Oct 25, 2024 · 4 comments
Closed

TSC Build #195

louis49 opened this issue Oct 25, 2024 · 4 comments

Comments

@louis49
Copy link

louis49 commented Oct 25, 2024

I've an error when transpiling my project with TSC using this library :

tsc

node_modules/cbor/types/lib/map.d.ts:48:5 - error TS2416: Property 'keys' in type 'CborMap' is not assignable to the same property in base type 'Map<any, any>'.
Type '() => Generator<any, void, unknown>' is not assignable to type '() => MapIterator'.
Call signature return types 'Generator<any, void, unknown>' and 'MapIterator' are incompatible.
The types returned by 'next(...)' are incompatible between these types.
Type 'IteratorResult<any, void>' is not assignable to type 'IteratorResult<any, undefined>'.
Type 'IteratorReturnResult' is not assignable to type 'IteratorResult<any, undefined>'.
Type 'IteratorReturnResult' is not assignable to type 'IteratorReturnResult'.
Type 'void' is not assignable to type 'undefined'.

48 keys(): Generator<any, void, unknown>;
~~~~

Found 1 error in node_modules/cbor/types/lib/map.d.ts:48

@louis49
Copy link
Author

louis49 commented Oct 25, 2024

Temporarily I added "skipLibCheck": true, to my tsconfig.json

@hildjj
Copy link
Owner

hildjj commented Oct 25, 2024

Does the cbor2 library show this same issue?

@hildjj
Copy link
Owner

hildjj commented Oct 25, 2024

I have reproduced the issue in this library, and don't see it in cbor2. Getting the tooling working again for this project is pretty labor-intensive, so I'm unlikely to be able to fix this in a reasonable timeframe.

Please move to cbor2 if you can.

@hildjj hildjj closed this as completed in 7902755 Oct 25, 2024
@hildjj
Copy link
Owner

hildjj commented Oct 25, 2024

I did get everything working at once, and just landed a fix for this. I'm going to see if anything else needs to be fixed before doing a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants