Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binaries for Mac Silicon #249

Open
PerretB opened this issue Nov 7, 2022 · 7 comments
Open

Add binaries for Mac Silicon #249

PerretB opened this issue Nov 7, 2022 · 7 comments
Labels
feature request Feature request

Comments

@PerretB
Copy link
Member

PerretB commented Nov 7, 2022

Probably need to cross compile with CiBuildWheel

@PerretB PerretB added the feature request Feature request label Nov 7, 2022
@PerretB
Copy link
Member Author

PerretB commented Dec 8, 2022

Need extra env for cibuildwheel https://cibuildwheel.readthedocs.io/en/stable/faq/#apple-silicon

Cmake must be instructed to cross-compile pypa/cibuildwheel#1345 (comment)

If activated TBB should also be cross-compiled... not sure if this is worth supporting, maybe wait until mac silicon is natively available in Azure agents

make -j tbb

@JoOkuma
Copy link
Contributor

JoOkuma commented Jun 20, 2023

Hi @PerretB, are you planning to add an Apple silicon binary?

Some collaborators are compiling from source to use on their laptops.

I really like using higra, thanks a lot for this package.

cc: @ilan-francisco

@PerretB
Copy link
Member Author

PerretB commented Jun 21, 2023

Hi Jordão,

thank you for your feedback, it's a pleasure to know that Higra is useful to you.

It's great news that your colleagues have been able to compile from source and use it on ARM because I never tested it :)

I plan to add Mac ARM support, but I'm a bit stuck as free CI/CD pipelines don't currently offer such hardware. I can try to cross compile it from an x86 Mac, but then I don't know how to test the result, and I am very reluctant to publish non-tested wheels on Pypi. Microsoft Azure seems to have a plan for supporting this, but the issue looks staled microsoft/azure-pipelines-agent#3922

Maybe a temporary solution could be to publish untested wheels on github with a download link. It would not be as convenient as publishing it on Pypi as users would have to download the wheel manually, but it would still be easier than compiling it manually.

On a side note: another solution for your colleagues is to install the amd_x86 version of Python with Rosetta 2.

@JoOkuma
Copy link
Contributor

JoOkuma commented Jun 21, 2023

Thanks for the quick reply @PerretB.
I completely agree with not pushing to pypi untested binaries.
We can continue installing from the source until a free OSX ARM CI is available.
Thanks again.

@patrickbreier
Copy link

Hey there, I just wanted ask what is the matter on this subject since arm64 runners are now available on GitHub (https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/).
Thank you guys for your work!

@PerretB
Copy link
Member Author

PerretB commented Mar 5, 2024

Oh thank you for pointing this. I'll set up the CI/CD then, hopefully everything goes smoothly, and binaries will be available soon for Mac silicon

Edit: apparently ATM only Github actions supports M1, but not Azure pipelines actions/runner-images#7508 (comment) (which this repo is currently using). Updated issue on azure agents, seems to be moving actions/runner-images#8971

@PerretB
Copy link
Member Author

PerretB commented May 21, 2024

mac-arm64 is now supported through conda higra-feedstock thanks to @JoOkuma

conda install higra -c conda-forge

It will be added to Pypi as soon as arm64 agents are available on Azure pipelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Feature request
Projects
None yet
Development

No branches or pull requests

3 participants