Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency @actions/http-client to v1.0.8 [SECURITY] #7

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 29, 2020

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@actions/http-client 1.0.7 -> 1.0.8 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2020-11021

Impact

If consumers of the http-client:

  1. make an http request with an authorization header
  2. that request leads to a redirect (302) and
  3. the redirect url redirects to another domain or hostname

The authorization header will get passed to the other domain.

Note that since this library is for actions, the GITHUB_TOKEN that is available in actions is generated and scoped per job with these permissions.

Patches

The problem is fixed in 1.0.8 at npm here. In 1.0.8, the authorization header is stripped before making the redirected request if the hostname is different.

Workarounds

None.

References

actions/http-client#27

For more information

If you have any questions or comments about this advisory:


Release Notes

actions/http-client

v1.0.8

Fixed security issue where a redirect (e.g. 302) to another domain would pass headers. The fix was to strip the authorization header if the hostname was different. More details in PR #​27


Renovate configuration

📅 Schedule: "" in timezone Asia/Tokyo.

🚦 Automerge: Enabled.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added the renovate label Apr 29, 2020
@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #7 (934acba) into master (33bb138) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master        #7   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          117       117           
  Branches         7         7           
=========================================
  Hits           117       117           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33bb138...934acba. Read the comment docs.

@renovate renovate bot force-pushed the renovate/npm-@actions/http-client-vulnerability branch 28 times, most recently from 2663692 to 37451d8 Compare May 1, 2020 06:51
@renovate renovate bot force-pushed the renovate/npm-@actions/http-client-vulnerability branch 23 times, most recently from 8b31fc1 to 2e6b74d Compare July 1, 2020 17:00
@renovate renovate bot force-pushed the renovate/npm-@actions/http-client-vulnerability branch from 2e6b74d to 233e830 Compare July 10, 2020 08:58
@renovate renovate bot force-pushed the renovate/npm-@actions/http-client-vulnerability branch from 233e830 to f8ae341 Compare August 23, 2020 06:59
@renovate renovate bot force-pushed the renovate/npm-@actions/http-client-vulnerability branch from f8ae341 to 390c4f9 Compare October 29, 2020 07:00
@renovate renovate bot force-pushed the renovate/npm-@actions/http-client-vulnerability branch from 390c4f9 to 934acba Compare November 27, 2020 00:54
@higebu higebu merged commit 77983a4 into master Dec 3, 2020
@renovate renovate bot deleted the renovate/npm-@actions/http-client-vulnerability branch December 3, 2020 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants