Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@NamedStoredProcedure and createNamedStoredProcedureQuery() #637

Open
DavideD opened this issue Mar 2, 2021 · 8 comments
Open

@NamedStoredProcedure and createNamedStoredProcedureQuery() #637

DavideD opened this issue Mar 2, 2021 · 8 comments
Labels
design A design or implementation issue enhancement New feature or request

Comments

@DavideD
Copy link
Member

DavideD commented Mar 2, 2021

I don't think it's critical at the moment but I've noticed we don't have an equivalent of createNamedStoredProcedureQuery.
@gavinking is it something that we want to have eventually?

@DavideD DavideD added design A design or implementation issue enhancement New feature or request labels Mar 2, 2021
@gavinking
Copy link
Member

I guess you're going to tell me we need it for the getOutputParameterValue() method?

@gavinking gavinking changed the title @NamedStoredProcedure @NamedStoredProcedure and createNamedStoredProcedureQuery() Mar 2, 2021
@gavinking
Copy link
Member

I don't see where the Vert.x client even supports output parameters yet.

@DavideD
Copy link
Member Author

DavideD commented Mar 2, 2021

To be honest I haven't given it much thought.

I was thinking that a user might want to call a stored procedure that it's defined using the annotation.
Considering that the reactive API doesn't have a method to do it, it should be clear enough that we don't support it.
Plus, it should work with a native query anyway if they want to call one.

I'm fine closing this issue and create a new one if somebody ask for it or when the Vert.x client offers support for calling stored procedures.

@gavinking
Copy link
Member

I was thinking that a user might want to call a stored procedure that it's defined using the annotation.

Well, as a temporary measure we could probably just let them call it as a regular native query, no? That should work at least for stored procedures that return exactly one result set. WDYT?

@DavideD
Copy link
Member Author

DavideD commented Mar 2, 2021

Well, as a temporary measure we could probably just let them call it as a regular native query, no?

Can't they just do that? They don't need to use @NamedStoredProcedure for it, isn't it?

@gavinking
Copy link
Member

They can, I thought you were worried that they might be already using the @NamedStoredProcedure for that and didn't want to dupe it.

@gavinking
Copy link
Member

Anyway, I propose that we just leave this issue open and unscheduled until someone asks for it.

@DavideD
Copy link
Member Author

DavideD commented Mar 2, 2021

Sounds good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design or implementation issue enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants