Lock handling support #4009
Merged
Lock handling support #4009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ All commit messages should start with a JIRA issue key matching pattern › This message was automatically generated. |
beikov
force-pushed
the
lock-handling
branch
8 times, most recently
from
08b921a
to
c4c129f
Compare
beikov
force-pushed
the
lock-handling
branch
11 times, most recently
from
24252d7
to
d3dca21
Compare
… the source alias to resolve lock mode during initializer creation. Introduce notion of aggregate function with an optional filter clause. Implement support for rendering locks into SQL. Move locking tests to orm package
| result = 31 * result + ( followOnLocking != null ? followOnLocking.hashCode() : 0 ); | ||
| result = 31 * result + ( scope ? 1 : 0 ); | ||
| return result; | ||
| } |
There was a problem hiding this comment.
It would be great to use Objects static util methods to simplify, if only from code readability perspective.
| @Override | ||
| public boolean supportsNoWait() { | ||
| return getVersion() >= 2010; | ||
| } |
There was a problem hiding this comment.
maybe we can reuse this method in other methods to centralize the logic.
| @@ -3515,6 +3534,15 @@ public boolean supportsNoWait() { | |||
| return false; | |||
| } | |||
|
|
|||
| /** | |||
| * Does this dialect/database support WAIT timeout. | |||
There was a problem hiding this comment.
super minor, but a '?' seems better alternative at the end of sentence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LockModein SqlAst andFetch/DomainResultwith source alias to resolve lock modes right before executionDialectmethodsgetWriteLockRowIdentifier(),getReadLockRowIdentifier()as replacement forforUpdateOfColumns** Needed to determine whether follow on locking is required
SelfRenderingSqmAggregateFunctionfor rendering SQL FILTER clause