refactor(vite-node-miniflare): replace hattip with h3 for internal middleware #135

hi-ogawa · 2023-12-15T00:15:47Z

part of TODO: vite-node-miniflare #127

It's a little ergonomically nicer to just install h3 (instead of multiple @hattip/.... packages), but it seem proxying request.body is not working with miniflare?

error log

# test POST API on React Router SSR demo
$ pnpm dev-react-router
..
[h3] [unhandled] TypeError: fetch failed
    at fetch (/home/hiroshi/code/personal/vite-plugins/node_modules/.pnpm/[email protected]/node_modules/undici/index.js:112:15)
    at async fetch2 (/home/hiroshi/code/personal/vite-plugins/node_modules/.pnpm/[email protected]/node_modules/miniflare/dist/src/index.js:4584:20)
    at async Miniflare.dispatchFetch (/home/hiroshi/code/personal/vite-plugins/node_modules/.pnpm/[email protected]/node_modules/miniflare/dist/src/index.js:9021:22)
    at async Object.handler (file:///home/hiroshi/code/personal/vite-plugins/node_modules/.pnpm/[email protected]/node_modules/h3/dist/index.mjs:1675:19)
    at async toNodeHandle (file:///home/hiroshi/code/personal/vite-plugins/node_modules/.pnpm/[email protected]/node_modules/h3/dist/index.mjs:1885:7) {
  cause: RequestContentLengthMismatchError: Request body length does not match content-length header
      at AsyncWriter.end (/home/hiroshi/code/personal/vite-plugins/node_modules/.pnpm/[email protected]/node_modules/undici/lib/client.js:2246:15)
      at writeIterable (/home/hiroshi/code/personal/vite-plugins/node_modules/.pnpm/[email protected]/node_modules/undici/lib/client.js:2129:12)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
    code: 'UND_ERR_REQ_CONTENT_LENGTH_MISMATCH'
  },
  statusCode: 500,
  fatal: false,
  unhandled: true,
  statusMessage: undefined,
  data: undefined
}
[vite-node-miniflare] invalidateDepTree: { invalidatedModules: [], invalidatedTree: Set(0) {} }
[mf:inf] POST /hello 200 OK (3ms)
workerd/server/server.c++:2838: error: Uncaught exception: kj/async-io-unix.c++:186: disconnected: remote.worker_do_not_log; Request failed due to internal error
stack: /home/hiroshi/code/personal/vite-plugins/node_modules/.pnpm/@[email protected]/node_modules/@cloudflare/workerd-linux-64/bin/workerd@3a68f8f /home/hiroshi/code/personal/vite-plugins/node_modules/.pnpm/@[email protected]/node_modules/@cloudflare/workerd-linux-64/bin/workerd@3a69ab1 /home/hiroshi/code/personal/vite-plugins/node_modules/.pnpm/@[email protected]/node_modules/@cloudflare/workerd-linux-64/bin/workerd@28c3b1b /home/hiroshi/code/personal/vite-plugins/node_modules/.pnpm/@[email protected]/node_modules/@cloudflare/workerd-linux-64/bin/workerd@3a464f0 /home/hiroshi/code/personal/vite-plugins/node_modules/.pnpm/@[email protected]/node_modules/@cloudflare/workerd-linux-64/bin/workerd@1fbb1e7 /home/hiroshi/code/personal/vite-plugins/node_modules/.pnpm/@[email protected]/node_modules/@cloudflare/workerd-linux-64/bin/workerd@209f370 /home/hiroshi/code/personal/vite-plugins/node_modules/.pnpm/@[email protected]/node_modules/@cloudflare/workerd-linux-64/bin/workerd@1f3d350 /home/hiroshi/code/personal/vite-plugins/node_modules/.pnpm/@[email protected]/node_modules/@cloudflare/workerd-linux-64/bin/workerd@1f3e0d5 /home/hiroshi/code/personal/vite-plugins/node_modules/.pnpm/@[email protected]/node_modules/@cloudflare/workerd-linux-64/bin/workerd@1deebf0 /home/hiroshi/code/personal/vite-plugins/node_modules/.pnpm/@[email protected]/node_modules/@cloudflare/workerd-linux-64/bin/workerd@1def160 /home/hiroshi/code/personal/vite-plugins/node_modules/.pnpm/@[email protected]/node_modules/@cloudflare/workerd-linux-64/bin/workerd@1df0040 /home/hiroshi/code/personal/vite-plugins/node_modules/.pnpm/@[email protected]/node_modules/@cloudflare/workerd-linux-64/bin/workerd@1df0670 /home/hiroshi/code/personal/vite-plugins/node_modules/.pnpm/@[email protected]/node_modules/@cloudflare/workerd-linux-64/bin/workerd@18a3f70 /home/hiroshi/code/personal/vite-plugins/node_modules/.pnpm/@[email protected]/node_modules/@cloudflare/workerd-linux-64/bin/workerd@28b295b /home/hiroshi/code/personal/vite-plugins/node_modules/.pnpm/@[email protected]/node_modules/@cloudflare/workerd-linux-64/bin/workerd@28b1e50 /home/hiroshi/code/personal/vite-plugins/node_modules/.pnpm/@[email protected]/node_modules/@cloudflare/workerd-linux-64/bin/workerd@189d530 /home/hiroshi/code/personal/vite-plugins/node_modules/.pnpm/@[email protected]/node_modules/@cloudflare/workerd-linux-64/bin/workerd@1f3d610 /home/hiroshi/code/personal/vite-plugins/node_modules/.pnpm/@[email protected]/node_modules/@cloudflare/workerd-linux-64/bin/workerd@1f3da44 /home/hiroshi/code/personal/vite-plugins/node_modules/.pnpm/@[email protected]/node_modules/@cloudflare/workerd-linux-64/bin/workerd@1df0670 /home/hiroshi/code/personal/vite-plugins/node_modules/.pnpm/@[email protected]/node_modules/@cloudflare/workerd-linux-64/bin/workerd@18bf78b /home/hiroshi/code/personal/vite-plugins/node_modules/.pnpm/@[email protected]/node_modules/@cloudflare/workerd-linux-64/bin/workerd@28c4d8c /home/hiroshi/code/personal/vite-plugins/node_modules/.pnpm/@[email protected]/node_modules/@cloudflare/workerd-linux-64/bin/workerd@28c5b93 /home/hiroshi/code/personal/vite-plugins/node_modules/.pnpm/@[email protected]/node_modules/@cloudflare/workerd-linux-64/bin/workerd@28c6194 /home/hiroshi/code/personal/vite-plugins/node_modules/.pnpm/@[email protected]/node_modules/@cloudflare/workerd-linux-64/bin/workerd@288b0b0

Also, response headers aren't propagated properly, which breaks data request convention using x-loader-response header?

curl examples

# before
$ curl -X GET -I "http://localhost:5173/loader-data?loader-route-id=%2Floader-data"
HTTP/1.1 200 OK
Access-Control-Allow-Origin: *
content-length: 26
content-type: application/json; charset=utf-8
x-loader-response: 1
Date: Fri, 15 Dec 2023 00:57:41 GMT
Connection: keep-alive
Keep-Alive: timeout=5

# after
curl -X GET -I "http://localhost:5173/loader-data?loader-route-id=%2Floader-data"
HTTP/1.1 200 OK
Access-Control-Allow-Origin: *
content-type: default
Date: Fri, 15 Dec 2023 00:56:21 GMT
Connection: keep-alive
Keep-Alive: timeout=5
Content-Length: 26

hi-ogawa · 2023-12-15T00:39:03Z

packages/vite-node-miniflare/src/server/plugin.ts

+      const app = h3.createApp().use([
+        h3.eventHandler((event) =>
+          viteNodeServerRpc.requestHandler({
+            request: h3.toWebRequest(event),


This might be due to calling toWebRequest twice in custom handler?

toWebRequest starts reading request body eagerly, and we should make it lazy (start reading when a body function is called) unjs/h3#570

EDIT: temporary workaround? fa72b7c

hi-ogawa · 2023-12-18T06:44:42Z

packages/vite-node-miniflare/src/server/plugin.ts

+        const request = h3.toWebRequest(event) as any as MiniflareRequest;
        return miniflare.dispatchFetch(request.url, {


Another blocker... Miniflare probably uses its own Request/Response polyfills and it breaks h3's isWebResponse check https://github.com/unjs/h3/blob/53703dc860f1ff6fe7ce71d543deff1cfa810b11/src/utils/response.ts#L209-L211

Fixed by 65258b0

hi-ogawa · 2024-06-10T01:34:11Z

Closing as it's obsolete

refactor(vite-node-miniflare): replace h3 with hattip for middleware

1450914

hi-ogawa changed the title ~~refactor(vite-node-miniflare): replace h3 with hattip for middleware~~ refactor(vite-node-miniflare): replace hattip with h3 for internal middleware Dec 15, 2023

hi-ogawa added 2 commits December 15, 2023 09:35

Merge branch 'main' into refactor-vite-node-middleware-hattip-to-h3

e3d5625

chore: lint

e2064e5

hi-ogawa commented Dec 15, 2023

View reviewed changes

fix: workaround double toWebRequest?

fa72b7c

hi-ogawa mentioned this pull request Dec 15, 2023

TODO: vite-node-miniflare #127

Closed

19 tasks

Merge branch 'main' into refactor-vite-node-middleware-hattip-to-h3

2e39a2a

hi-ogawa commented Dec 18, 2023

View reviewed changes

hi-ogawa added 3 commits December 18, 2023 15:49

fix: fix mismatch Response class

65258b0

refactor: minor

bc9e830

refactor: minor

0174dda

hi-ogawa marked this pull request as ready for review December 18, 2023 06:54

chore: cleanup deps

47e262e

hi-ogawa mentioned this pull request Dec 21, 2023

refactor(demo): use h3/nitro for deployment packaging #146

Closed

5 tasks

hi-ogawa closed this Jun 10, 2024

hi-ogawa deleted the refactor-vite-node-middleware-hattip-to-h3 branch June 10, 2024 01:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(vite-node-miniflare): replace hattip with h3 for internal middleware #135

refactor(vite-node-miniflare): replace hattip with h3 for internal middleware #135

hi-ogawa commented Dec 15, 2023 •

edited

Loading

hi-ogawa Dec 15, 2023 •

edited

Loading

hi-ogawa Dec 18, 2023

hi-ogawa Dec 18, 2023

hi-ogawa commented Jun 10, 2024

		const request = h3.toWebRequest(event) as any as MiniflareRequest;
		return miniflare.dispatchFetch(request.url, {

refactor(vite-node-miniflare): replace hattip with h3 for internal middleware #135

refactor(vite-node-miniflare): replace hattip with h3 for internal middleware #135

Conversation

hi-ogawa commented Dec 15, 2023 • edited Loading

hi-ogawa Dec 15, 2023 • edited Loading

Choose a reason for hiding this comment

hi-ogawa Dec 18, 2023

Choose a reason for hiding this comment

hi-ogawa Dec 18, 2023

Choose a reason for hiding this comment

hi-ogawa commented Jun 10, 2024

hi-ogawa commented Dec 15, 2023 •

edited

Loading

hi-ogawa Dec 15, 2023 •

edited

Loading