Skip to content
This repository has been archived by the owner on Dec 1, 2024. It is now read-only.

Disable some lint rules by default #421

Closed
Atry opened this issue Dec 9, 2021 · 2 comments · Fixed by #422
Closed

Disable some lint rules by default #421

Atry opened this issue Dec 9, 2021 · 2 comments · Fixed by #422

Comments

@Atry
Copy link
Contributor

Atry commented Dec 9, 2021

This linter might also be good for the default blacklist - there's an ongoing discussion about removing it entirely at https://fb.workplace.com/groups/hackforhiphop/posts/7429940763721141

In short: It's accurate, but it's highly opinionated, and there's not consensus on the behavior it encourages being a good thing.

This isn't the same as the other codes we'd want to always-ignore, but "pretend it doesn't exist" may be the right thing to do for "may be deleted soon". Perhaps making it off-by-default but explicitly-includable may be better.

Originally posted by @fredemmott in #418 (comment)

@lexidor
Copy link
Contributor

lexidor commented Dec 9, 2021

What lint number are you referring to? Non-fb contributors can't access the link you posted.

@fredemmott
Copy link
Contributor

Sorry, 5639 - I edited it into the orignal comment but didn't spot here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants