Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State errors display in ProB2UI not very readable and sometimes fails #328

Open
leuschel opened this issue Oct 17, 2023 · 3 comments
Open
Labels
bug Something isn't working prob_prolog Issue related to ProB's Prolog kernel ProB2UI Issue related to JavaFX ProB2UI

Comments

@leuschel
Copy link
Member

The display of state errors (in particular WD errors) is not very user friendly and seems to fail for this example here.
In Tcl/Tk you also have the option to visualise some errors (i.e., get a graphical formula tree explaining the cause of the error).
Screenshot 2023-10-14 at 09 32 40

@leuschel leuschel added bug Something isn't working ProB2UI Issue related to JavaFX ProB2UI labels Oct 17, 2023
@dgelessus
Copy link

The "Sorry, the detailed output failed." message appears quite often. It comes from the Prolog side - see explain_state_error/3 in translate.pl. There's probably a bug somewhere there that breaks the detailed error output.

@leuschel
Copy link
Member Author

There was a bug in prob2_interface:convert_errors which
was setting the Span to unkonwn.
Fixed in 503b361334a0feb2cf19ec9add9f47a02487bee3
But we should probably use this span in some way, I think Tcl/Tk uses it for the Visualize button if the span contains a span predicate.

@leuschel
Copy link
Member Author

The call stack (if available) is now also shown in the ProB2UI view

@iTitus iTitus added the prob_prolog Issue related to ProB's Prolog kernel label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working prob_prolog Issue related to ProB's Prolog kernel ProB2UI Issue related to JavaFX ProB2UI
Projects
None yet
Development

No branches or pull requests

3 participants