Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Path and PathComponent hash and hashValue is simply memory address #47

Closed
hfutrell opened this issue Jun 7, 2019 · 1 comment · Fixed by #104
Closed

Path and PathComponent hash and hashValue is simply memory address #47

hfutrell opened this issue Jun 7, 2019 · 1 comment · Fixed by #104

Comments

@hfutrell
Copy link
Owner

hfutrell commented Jun 7, 2019

this means that Swift classes that depend on Hashable such as Set will fail to locate instances that are identical but do not share the same address, such as independent copies.

A good unit test of this behavior is to make a Path, add it to a Set, make a copy using Path.copy(using: CGAffineTransform.identity) and see if Set.contains() still locates it.
@hfutrell hfutrell changed the title Path and PathComponent hash and hashValue is simply pointer value Path and PathComponent hash and hashValue is simply memory address Jun 7, 2019
@vincentspitale vincentspitale mentioned this issue Dec 8, 2021
Merged
@hfutrell
Copy link
Owner Author

hfutrell commented Dec 9, 2021

fixed in 0.13.0

@hfutrell hfutrell closed this as completed Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hashable Path and PathComponent vincentspitale/BezierKit
1 participant
@hfutrell