Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mix hex.docs open should automatically fetch docs #290

Closed
ericmj opened this issue Sep 14, 2016 · 3 comments
Closed

mix hex.docs open should automatically fetch docs #290

ericmj opened this issue Sep 14, 2016 · 3 comments

Comments

@ericmj
Copy link
Member

ericmj commented Sep 14, 2016

No description provided.

@ericmj ericmj changed the title mix hex.docs open should automatically fetch package mix hex.docs open should automatically fetch docs Sep 14, 2016
@lexmag
Copy link
Contributor

lexmag commented Sep 24, 2016

I think it should happen thru dialog with user.

@fteem
Copy link
Contributor

fteem commented Sep 24, 2016

@lexmag @ericmj I noticed that #292 got merged just as I opened #293. Before, it was quite obvious what the behaviour should be. Right now, I am not so sure.

From my understanding, the command should check if the documentation is present. If not, it should prompt the user if they would like to fetch it locally. Something like:

mix hex.docs open phoenix --offline
** (Mix) Documentation file not found, would you like to download it? (Yn)

Your thoughts?

@josevalim
Copy link
Member

@fteem 👍 If the offline documentation is not available we should automatically fetch it.

@ericmj ericmj closed this as completed Sep 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants