Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The behaviour of the HEX_UNSAFE_REGISTRY boolean seems backwards #285

Closed
mcoms opened this issue Sep 2, 2016 · 2 comments
Closed

The behaviour of the HEX_UNSAFE_REGISTRY boolean seems backwards #285

mcoms opened this issue Sep 2, 2016 · 2 comments

Comments

@mcoms
Copy link

mcoms commented Sep 2, 2016

Setting HEX_UNSAFE_REGISTRY=1 causes hex to require a signed registry. Setting HEX_UNSAFE_REGISTRY=0 disables the signature check verification.

This is the opposite of what the warning message returned by hex when accessing an unsigned registry says.

The code here may need to be negated: https://github.com/hexpm/hex/blob/master/lib/hex/state.ex#L45

Hex: 0.13.0, Elixir: 1.3.2, OTP: 19.0.2

@ericmj
Copy link
Member

ericmj commented Sep 2, 2016

Thanks for the report, this is indeed incorrect. Would you mind sending a PR that adds the same Kernel.not as the line above and flips the default value?

sashman added a commit to sashman/hex that referenced this issue Sep 5, 2016
@lexmag
Copy link
Contributor

lexmag commented Sep 7, 2016

Closed in #287.

@lexmag lexmag closed this as completed Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants