Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new code block layout made it difficult to select and copy code without including the line number #145

Closed
ppoffice opened this issue Nov 30, 2019 · 3 comments

Comments

@ppoffice
Copy link

ppoffice commented Nov 30, 2019

Before the new layout:
I can select code and code only by hand or using clipboard.js
image

After the new layout:
Line number is also selected as each number is within the same line as the code
image

Related code:
https://github.com/hexojs/hexo-util/blob/master/lib/highlight.js#L45-L55

@SukkaW
Copy link
Member

SukkaW commented Dec 9, 2019

Related issue: hexojs/hexo#3884 hexojs/hexo#3913 401dde1#r36250206

@curbengh @stevenjoezhang @jiangtj

Since it is a serious Breaking Change that already breaks a lot of theme. I suggest to revert the PR #132 and release an emergency release of hexo-util & hexo.

@SukkaW
Copy link
Member

SukkaW commented Dec 9, 2019

@hexojs/core
Since the prismjs is already on the roadmap, IMHO we shouldn't bring any changes to current highlightjs since it will be deprecated soon.

@curbengh
Copy link
Contributor

#153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants