fix: fallback to error code when message is unset #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apricote
approved these changes
Nov 27, 2023
jooola
deleted the
ensure-api-exception-print-useful-info-on-server-error
branch
jooola
pushed a commit
that referenced
this pull request
Dec 19, 2023
🤖 I have created a release *beep* *boop* --- ## [1.33.0](v1.32.0...v1.33.0) (2023-12-19) ### Features * add metrics endpoint for load balancers and servers ([#331](#331)) ([ee3c54f](ee3c54f)) ### Bug Fixes * fallback to error code when message is unset ([#328](#328)) ([1c94153](1c94153)) ### Dependencies * update actions/setup-python action to v5 ([#335](#335)) ([2ac252d](2ac252d)) * update dependency sphinx-rtd-theme to v2 ([#330](#330)) ([7cc4335](7cc4335)) * update pre-commit hook psf/black-pre-commit-mirror to v23.12.0 ([#338](#338)) ([38e4748](38e4748)) * update pre-commit hook pycqa/isort to v5.13.0 ([#336](#336)) ([3244cfe](3244cfe)) * update pre-commit hook pycqa/isort to v5.13.1 ([#337](#337)) ([020a0ef](020a0ef)) * update pre-commit hook pycqa/isort to v5.13.2 ([#339](#339)) ([b46df8c](b46df8c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the API return a
server_error, it may not provide a message. This ensures that we printserver_noneinstead ofNonewhen printing the exception.