Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken on node 20.12.x #313

Closed
otaviojacobi opened this issue Apr 8, 2024 · 3 comments · Fixed by #314
Closed

Broken on node 20.12.x #313

otaviojacobi opened this issue Apr 8, 2024 · 3 comments · Fixed by #314
Labels

Comments

@otaviojacobi
Copy link

otaviojacobi commented Apr 8, 2024

Describe the bug
net-keepalive fails to install on node 20.12.x onwards.

To Reproduce

$ nvm use 20.12
Now using node v20.12.1 (npm v10.5.0)
$ npm i net-keepalive
...
npm ERR! /home/otavio/.cache/node-gyp/20.12.1/include/node/js_native_api.h:523:43: note:   initializing argument 4 of ‘napi_status napi_add_finalizer(napi_env, napi_value, void*, node_api_nogc_finalize, void*, napi_ref__**)’
npm ERR!   523 |                    node_api_nogc_finalize finalize_cb,
npm ERR!       |                    ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
npm ERR! make: *** [ffi_bindings.target.mk:121: Release/obj.target/ffi_bindings/src/ffi.o] Error 1
npm ERR! gyp ERR! build error 
npm ERR! gyp ERR! stack Error: `make` failed with exit code: 2
npm ERR! gyp ERR! stack at ChildProcess.<anonymous> (/home/otavio/.nvm/versions/node/v20.12.1/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:209:23)
npm ERR! gyp ERR! System Linux 6.5.0-26-generic
npm ERR! gyp ERR! command "/home/otavio/.nvm/versions/node/v20.12.1/bin/node" "/home/otavio/.nvm/versions/node/v20.12.1/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
npm ERR! gyp ERR! cwd /home/otavio/git/test-napi/node_modules/ffi-napi
npm ERR! gyp ERR! node -v v20.12.1
npm ERR! gyp ERR! node-gyp -v v10.0.1
npm ERR! gyp ERR! not ok

Expected behavior
net-keepalive would install :)

Package (please complete the following information):

  • OS: all
  • Node: 20.12.x
  • Version: 3.0.1

Additional context
This is failing due to a breaking change on node please see nodejs/node#52229
I think also ff-napi sadly is unmantained: node-ffi-napi/node-ffi-napi#269
Do you have any plans or are considering migrating to any of the possible substitutes?

@hertzg
Copy link
Owner

hertzg commented Apr 12, 2024

Hello, I've started a draft PR for this.

@all-contributors please add @otaviojacobi for bug

Copy link
Contributor

@hertzg

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @otaviojacobi! 🎉

Copy link
Contributor

🎉 This issue has been resolved in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants