Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auras] New tracking for players + all direct reachable unitid but nameplates #10

Open
aethys256 opened this issue Aug 1, 2017 · 2 comments
Assignees

Comments

@aethys256
Copy link
Member

Instead of tracking it on demand on each pulse, rather make an event listener to build the buffs table (on aura applied / removed).
Player is the top priority but the handler should be flexible to take any UnitIDs/GUID (so, in the future it could be extended to UnitIDs even if the GUID changes, which is something that can happen with nameplates tracking especially).

@aethys256 aethys256 self-assigned this Aug 1, 2017
@aethys256 aethys256 changed the title [Buffs] New tracking for players + all direct reachable unitid but nameplates [Auras] New tracking for players + all direct reachable unitid but nameplates Aug 1, 2017
@aethys256
Copy link
Member Author

@EvanMichaels did a first step towards this direction in 78228fc . Might re-use that for Auras since it's one of the other big resource consumer.

@aethys256
Copy link
Member Author

Still planned for Shadowlands development.
Talked with WA folks to know if they were interested to make their internal tracker an external lib in order to improve overall addons performance since it means that each addon has to reimplement the same system (and thus duplicate both the processing power and memory storage requirements).
They are not interested so I will either make it its own lib and use it inside HL or just add it into HL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant