Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CPRA link to footer #335

Merged
merged 5 commits into from
May 30, 2023
Merged

Add CPRA link to footer #335

merged 5 commits into from
May 30, 2023

Conversation

johlym
Copy link

@johlym johlym commented May 30, 2023

This PR adds a required CPRA link to the footer of all pages. It also bumps the Ruby version to 3.x for further support and the stack to Heroku 22.

@johlym johlym self-assigned this May 30, 2023
@heroku heroku bot temporarily deployed to twelve-facto-johlym-cpr-tg16pj May 30, 2023 22:26 Inactive
Copy link
Member

@mars mars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shiny Ruby 💎

All looks good.

@@ -1,3 +1,4 @@
.rvmrc
.bundle
.tool-versions
.DS_Store
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, and also the repetitiveness of doing it for every single repo can be avoided by adding it to your home gitignore:

echo ".DS_Store" > $HOME/.gitignore

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@johlym johlym merged commit 6439c83 into master May 30, 2023
@johlym johlym deleted the johlym/cpra branch May 30, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants