feat(uhyvefilemap): improve guest path handling #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n0toose
force-pushed
the
sandbox-guest-paths
branch
2 times, most recently
from
f661d85 to
c9cd2eb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #844 +/- ##
=======================================
Coverage 71.85% 71.86%
=======================================
Files 23 23
Lines 3063 3064 +1
=======================================
+ Hits 2201 2202 +1
Misses 862 862 ☔ View full report in Codecov by Sentry. |
n0toose
force-pushed
the
sandbox-guest-paths
branch
3 times, most recently
from
95418e5 to
fd837f7
Compare
jounathaen
reviewed
Jan 9, 2025
n0toose
force-pushed
the
sandbox-guest-paths
branch
from
50f2221 to
12ca0cd
Compare
Until now, guest paths were not canonicalized. This would mean that Uhyve would not be able to see that, for example, "/root" and "/root/directory/.." are both locations referring to the same directory. This requires a new dependency for now, although we should remove it once Path::normalize_lexically is implemented and part of Rust. This also "removes" support for empty, mapped guest paths. Fixes hermit-os#815.
We also began using .display().to_string(), so as to drop non-Unicode characters, similarly to when parsing the mappings.
n0toose
force-pushed
the
sandbox-guest-paths
branch
from
12ca0cd to
a851879
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, guest paths were not canonicalized.
This would mean that Uhyve would not be able to see that, for example, "/root" and "/root/directory/.." are both locations referring to the same directory. This requires a new dependency for now, although we should remove it once Path::normalize_lexically is implemented and part of Rust.
This also "removes" support for empty, mapped guest paths.
Fixes #815.