Improved memory size checking. #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkroening
reviewed
Jun 28, 2023
|
As discussed in person, I think this approach is fine, as it results in a moreless helpful error message upon failure. |
mkroening
approved these changes
Jun 28, 2023
jounathaen
force-pushed
the
check_memsize
branch
from
28871f8
to
5346d86
Compare
Co-authored-by: Martin Kröning <[email protected]>
jounathaen
force-pushed
the
check_memsize
branch
from
5346d86
to
3d3aee8
Compare
Codecov Report
@@ Coverage Diff @@
## master #533 +/- ##
==========================================
- Coverage 65.68% 65.64% -0.05%
==========================================
Files 18 18
Lines 2116 2119 +3
==========================================
+ Hits 1390 1391 +1
- Misses 726 728 +2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for multiple of hugepagesize.
Related: #265