Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Don't run slow KVM tests on every PR #175

Merged
merged 3 commits into from
Sep 1, 2021
Merged

CI: Don't run slow KVM tests on every PR #175

merged 3 commits into from
Sep 1, 2021

Conversation

mkroening
Copy link
Member

It is still required via bors.

@mkroening
CI: Don't run slow KVM tests on every PR
277e443 
It is still required via bors.
@mkroening mkroening requested a review from jounathaen August 30, 2021 13:50
@codecov
Copy link

codecov bot commented Aug 30, 2021 •
edited
Loading

Codecov Report

Merging #175 (843edac) into master (4a11e47) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #175   +/-   ##
=======================================
  Coverage   30.76%   30.76%           
=======================================
  Files          16       16           
  Lines        4017     4017           
=======================================
  Hits         1236     1236           
  Misses       2781     2781

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a11e47...843edac. Read the comment docs.

@jounathaen
Copy link
Member

Hmm, I'm a bit hesitant on this one.
This will definitely speed up things and make the whole process faster.
However, we will get faster machines for the KVM tests at sometime and more faster runners in parallel sounds like the better approach to me.
But we can use this solution until that point.

@mkroening
Don't run CI on pushes to master
159a254 
The CI for those commits has already been run on staging via bors.
@mkroening
Copy link
Member Author

I added two more commits.

It is really time consuming to wait for CI right now. One PR submission causes 9 CI jobs (three jobs each on PR, on staging and on master) which are serially executed on our one runner. This really quickly builds up.

I changed the config to not run CI on master again, since that exact commit has already been tested on staging by bors.

Until we can do CI in parallel, this would make my life a lot easier.

@mkroening
CI: Do scheduled tests at 05:00 on Monday
843edac 
Instead of 00:00 on Sunday

This is also the default for dependabot.
@jounathaen
Copy link
Member

Well, we don't want that, do we?
bors r+

@bors
Copy link
Contributor

bors bot commented Aug 30, 2021

Timed out.

@mkroening
Copy link
Member Author

bors retry

@bors
Copy link
Contributor

bors bot commented Aug 31, 2021

Build failed:

@mkroening
Copy link
Member Author

The failure is not related to this PR, but to the newest nightly.

@mkroening
Copy link
Member Author

bors retry

@bors
Copy link
Contributor

bors bot commented Sep 1, 2021

Build succeeded:

@bors bors bot merged commit cd2e0b6 into hermit-os:master Sep 1, 2021
@mkroening mkroening deleted the bors-only-kvm-ci branch September 1, 2021 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jounathaen jounathaen Awaiting requested review from jounathaen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkroening @jounathaen