Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rerun with strings.Builder? #8

Open
btanner opened this issue Apr 8, 2019 · 1 comment
Open

Rerun with strings.Builder? #8

btanner opened this issue Apr 8, 2019 · 1 comment

Comments

@btanner
Copy link

btanner commented Apr 8, 2019 •
edited
Loading

Hi. It's a bit of work for me to submit code from work, but I would encourage you to run this again and include strings.Builder in the mix.

From my own test, it is faster than some of the alternatives, and simpler.
@hermanschaaf
Copy link
Owner

Good point, I expect it to be faster too. But haven't had the time to do the test yet. PRs welcome, otherwise I'll update the code and post when I have some time in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hermanschaaf @btanner