Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook from Sonar contains #number of PR instead of branch name #4

Closed
juldou opened this issue Mar 21, 2022 · 3 comments
Closed

Webhook from Sonar contains #number of PR instead of branch name #4

juldou opened this issue Mar 21, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@juldou
Copy link
Contributor

juldou commented Mar 21, 2022

Hello, thank you for your project.

We are considering using it, but we came into an issue, which can also be caused by our settings.

In the code, you are parsing the branch name, but from Sonar Webhook, the data contains PR number (and it fails as it is not valid branch name). From Sonar Webhook (Sonar Enterprise) we are getting following data:

"branch": { "name": "45", "type": "PULL_REQUEST", "isMain": false, }

I wanted to discuss this with you in advance, but I was not able to find any contact email or anything.

Thank you.

@juldou
Copy link
Contributor Author

juldou commented Mar 22, 2022

I am already working on support for PULL_REQUEST type. Change is trivial.

@herlon214
Copy link
Owner

Hey @juldou thank you very much for helping to build this 💪
Let me know if you need any help

@herlon214 herlon214 added the bug Something isn't working label Mar 23, 2022
@juldou
Copy link
Contributor Author

juldou commented Mar 23, 2022

Fix of this issue + boolean flag to allow commenting without requesting changes - #5

If you insist on splitting it to 2 separate PR's, let me know.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants